Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pretrigger samples #23

Open
pollockm opened this issue Feb 7, 2017 · 3 comments
Open

Add pretrigger samples #23

pollockm opened this issue Feb 7, 2017 · 3 comments
Assignees

Comments

@pollockm
Copy link
Contributor

pollockm commented Feb 7, 2017

To enable a postmortem analysis, add pretrigger samples for the log. Currently we only start collecting data to log once we see the enable line go high - why not add a circular buffer in front of that?

@pollockm pollockm self-assigned this Feb 7, 2017
@pollockm
Copy link
Contributor Author

pollockm commented Feb 8, 2017

I'd likely have the pretrigger buffer size forced to be a multiple of the 'scans per write' property that we already use, since that is already the chunk size of the FIFO.

@pollockm
Copy link
Contributor Author

pollockm commented Feb 8, 2017

Also need some form of option for trigger arming - if trigger value goes high before the pretrigger buffer is full, do we ignore until buffer full or immediately start dumping data to disk? I prefer the 'ignore until buffer full' behavior, but we might need to expose that option

@smithed
Copy link
Member

smithed commented Feb 9, 2017

If the trigger is a failure condition then you'd want pre-trigger samples even if the buffer isn't full, as some data is better than none. Unless the trigger was latched, in which case I think it would be fine to fill the buffer and then flush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants