You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There seem to be unnecessarily many components in this repository. For example: ItemIcon vs SummonerIcon vs (until more recently) TrinketIcon. The components that do exist are also very tightly coupled, for example VictoryBar requires that it be in a Match. We need to think hard about what it means to write a reusable component. In general, we shouldn't have to create a new component for every little feature/widget that we create.
There seem to be unnecessarily many components in this repository. For example:
ItemIcon
vsSummonerIcon
vs (until more recently)TrinketIcon
. The components that do exist are also very tightly coupled, for exampleVictoryBar
requires that it be in aMatch
. We need to think hard about what it means to write a reusable component. In general, we shouldn't have to create a new component for every little feature/widget that we create.Rangle's react-redux-starter is a good place to take some guidance.
The text was updated successfully, but these errors were encountered: