Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing the point #17

Open
RSNara opened this issue Dec 16, 2015 · 0 comments
Open

Missing the point #17

RSNara opened this issue Dec 16, 2015 · 0 comments

Comments

@RSNara
Copy link
Contributor

RSNara commented Dec 16, 2015

There seem to be unnecessarily many components in this repository. For example: ItemIcon vs SummonerIcon vs (until more recently) TrinketIcon. The components that do exist are also very tightly coupled, for example VictoryBar requires that it be in a Match. We need to think hard about what it means to write a reusable component. In general, we shouldn't have to create a new component for every little feature/widget that we create.

Rangle's react-redux-starter is a good place to take some guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant