-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault at end of commandline render #588
Comments
Duplicate #238 |
Having a similar issue here, but with different output from gdb:
As metioned by @softrabbit above, the output file is generated and seems to be intact.
|
Does this still happen with stable-1.1 series from Git? |
I checked out stable-1.1, but the version reports 1.0.95 - is this expected?
|
Yes, that's normal. We back-number until we reach a stable. 1.1.0. |
Jist confirmed that this still happens on master with: https://github.com/SecondFlight/lmms/raw/master/data/projects/CoolSongs/Greippi%20-%20Krem%20Kaakkuja%20%28Second%20Flight%20Remix%29.mmpz |
Lots of different backtraces for the same problem :/. I guess lmms is eager to delete buffers or something while there's still sound being processed... Just to be clear, the whole song gets written correctly to the output file, so this is an issue that happens when tearing down internal resources for the exit. Yet another backtrace gist: https://gist.github.com/badosu/ce6c6d64050416c6aae1 |
Yeah, looking at the source code it looks like this is indeed the case, see how the app is allowed to be deleted before resources are teared down: https://github.com/LMMS/lmms/blob/master/src/core/main.cpp#L533-539 . This should have a different logic for the CLI here, and not shared with the GUI, see: QCoreApplication::instance()->connect( r, SIGNAL( finished() ), SLOT( quit() ) ); |
Can you comfirm that this is still an issue @softrabbit? |
Different crash today, but segfault anyway.
|
@softrabbit Can you replicate this on 1.2 ? I believe this could possibly be an instance of #3555 which has been fixed. There were other command line render crashes fixed too in 1.2 . |
Closing because many CLI rendering bugs have been fixed since the time this bug report is created. Please feel free to reopen this issue if the crash still happens. |
This is what 1.0 and master branch occasionally seem to do at the end when rendering from command line. The output file gets created and rendered fine, so it's maybe not that critical.
The text was updated successfully, but these errors were encountered: