Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO Controller/Automation exports poorly #5665

Closed
Firepal opened this issue Sep 2, 2020 · 3 comments · Fixed by #5695
Closed

LFO Controller/Automation exports poorly #5665

Firepal opened this issue Sep 2, 2020 · 3 comments · Fixed by #5695
Assignees
Labels
Milestone

Comments

@Firepal
Copy link
Contributor

Firepal commented Sep 2, 2020

Bug Summary

Automating a property with an LFO Controller works fine in real-time playback, but it seems to be only occasionally sampled on export (regardless of the file format AFAIK), and sounds "stepped" as a result

Steps to reproduce

LMMS project file
bugrep.zip

Listen to the project file first, and then export to WAV or some other format

if you want to do it manually with the default file:
  1. Add an LFO Controller with any settings (Sine wave and tempo-synced to Eight Beats for example)

  2. Connect it to a Coarse Detuning knob in the TripleOscillator

  3. Add a pattern with a long note and play it in the Song Editor; the TripleOsc should sound fine as expected

  4. Export it to some audio file format and listen to the exported file

Expected behavior

The exported audio file sounds like the real-time playback of LMMS with no issues

Actual behavior

The exported audio file has very noticeable "jumps" in the LFO Controller

Screenshot

A little comparison of an exported file from LMMS (top track) and recorded real-time output from LMMS (bottom track) in Audacity
an Audacity screenshot of two tracks

bugrep-aup.zip

Affected LMMS versions

Branch: master. I've noticed this issue on stable 1.2.x as well.
This never occured in 1.1.3.

@Firepal Firepal added the bug label Sep 2, 2020
@DomClark
Copy link
Member

DomClark commented Sep 2, 2020

This is another issue with automatic signal-slot connections that should be direct instead. I fixed the ones in the core, LADSPA, and VST in #4692 and #4942, but didn't touch the built-in plugins.

@DomClark DomClark self-assigned this Sep 2, 2020
@DomClark DomClark added this to the 1.3 milestone Sep 2, 2020
@Firepal
Copy link
Contributor Author

Firepal commented Sep 21, 2020

Just took a leisurely stroll in the TripleOscillator's code to see if setting all the signals to be DirectConnections would fix this, and it did, and I'm definitely surprised that the fix is that small. But I'd venture to guess it would take a good chunk of time to add this fix to all of the plugins...

@Firepal Firepal changed the title LFO Controller (occasionally?) exports poorly LFO Controller/Automation exports poorly Sep 21, 2020
@DomClark
Copy link
Member

I'm not currently working on this, so if you'd like to open a PR with your changes, that would be very welcome. Don't worry about fixing all the plugins at once - any fix is better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants