Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu entry "remove all linked controllers" is bad wording #5285

Closed
JohannesLorenz opened this issue Oct 29, 2019 · 12 comments
Closed

Menu entry "remove all linked controllers" is bad wording #5285

JohannesLorenz opened this issue Oct 29, 2019 · 12 comments
Labels
Milestone

Comments

@JohannesLorenz
Copy link
Contributor

It's bad because:

  • you don't remove the controller, but the connection
  • UI elements (like knobs) can also be linked to other UI elements (ctrl + drag-drop from one knob to another) instead of only to controllers.

Proposals:

  1. remove all connections
  2. remove all controller and model connections (does a user know what a model is? is the text too long?)

What shall we use?

@Spekular
Copy link
Member

Spekular commented Oct 29, 2019

For what it's worth, Serum calls its equivalent "Remove all modulators".

Alt proposals:

  • Remove all links
  • Disconnect all / Unlink all
    • Disconnect from all / Unlink from all

I think your second proposal is too long and "model" is a concept that the user shouldn't have to care about. After that I don't have much of a strong preference. Link/linked saves a few characters over connection/connected and is maybe less ambiguous, although the second point is minor and probably varies from person to person.

@Veratil
Copy link
Contributor

Veratil commented Oct 29, 2019

If we remove connections... Disconnect all controllers

@JohannesLorenz
Copy link
Contributor Author

"Remove all modulators".

Sounds good, though it still sounds like removing the modulators

"Disconnect all controllers"

Like mentioned above, connections don't always go to controllers.

So I'd be for "Disconnect everything". If no one disagrees within a few days, I'll open a PR.

Can such a PR go to stable-1.2? I ask because this will invalidate any translations... Not so good for a stable release? On the other hand, it's a bug fix...

@PhysSong
Copy link
Member

Disconnect everything

I disagree because users may think it disconnects automation patterns.

@Spekular
Copy link
Member

Spekular commented Oct 30, 2019

Oh, so it disconnects everything except automation tracks? That's hard to convey concisely.

What about something like "unlink controllers/knobs" then?

Length comparison of a few variants. I'm partial to the first:

"unlink controllers/knobs"
"unlink controllers & knobs"
"unlink controllers and knobs"
"remove all linked controllers"

@JohannesLorenz
Copy link
Contributor Author

I just tested what PhysSong said, it's indeed correct.

"unlink controllers/knobs"
"unlink controllers & knobs"
"unlink controllers and knobs"

It's not just knobs. Can be LEDs, LCD widgets, whatever. That's why I proposed models, but I agree that no one understands that. Maybe "widgets"?

"remove all linked controllers"

That's the current wording, with the issues mentioned in the 1st post.

Another idea: "Disconnect all except automation".

@Spekular
Copy link
Member

Spekular commented Oct 30, 2019

That's the current wording

Yes, I put it there as a reference for the current length of the string.

Anyway, what if we let "driver" = a knob* that drives another knob's value. Then we have a name to refer to these linked models (specifically to the master model) and can write "Disconnect controllers and drivers".

I think that's a bit more UI friendly than "Disconnect controllers and models".

*knob/LED/whatever.

@Spekular Spekular reopened this Oct 30, 2019
@Spekular
Copy link
Member

Hit the wrong button, again. I've edited my comment above to what it ahould have been.

@JohannesLorenz
Copy link
Contributor Author

I'm against introducing new vocabulary like "driver", but I like the idea of your removed post to name them "controls". "Disconnect all controllers and controls" sounds good to me. Or "Disconnect all modulators" like in Serum.

@Spekular
Copy link
Member

Spekular commented Oct 30, 2019 via email

@JohannesLorenz
Copy link
Contributor Author

I was so wrong. This comes from a German translation:

    <source>Remove all linked controls</source>
    <translation>Alle verknuepften Controller entfernen</translation>

You don't need to be a German expert to understand what they translated wrong.

I still don't like "Remove", but don't see it as critical. I'm fine with a transifex fix for the German translation.

@JohannesLorenz
Copy link
Contributor Author

Solved in transifex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants