Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC7 ZASFX -lmms-ui PITCH not played as saved #4721

Closed
musikBear opened this issue Dec 5, 2018 · 11 comments
Closed

RC7 ZASFX -lmms-ui PITCH not played as saved #4721

musikBear opened this issue Dec 5, 2018 · 11 comments

Comments

@musikBear
Copy link

OS : winXP sp3
LMMS RC7

Issue description:
The saved file-information for changed PITCH is not default replayed.
Instead the pitch is kept as 0 with 0 spread (default)

Recreate :
I have a file but board wont attach the zipped file :|
Here is a recording:
https://soundcloud.com/musikbear/pitchzasfx

  1. LOADED FROM DISK
  2. HOW IT WAS SAVED TO DISK

Factual event/ bug
I have figured out what happens:
The value that is saved, it not expressed, until the dial (here PITCH) has been altered. Any movement at all, will in replay, result in the correct value.
I wonder if it can be this issue that has made some user claim, that zasfx are 'resetting' itself. I tried with filter and reso -None of these behave in this way.

@musikBear
Copy link
Author

Cant upload zipped here (?) I dropped a demo file on LSP:
https://lmms.io/lsp/?action=show&file=14251

@zonkmachine
Copy link
Member

zonkmachine commented Dec 6, 2018

Error: Invalid file:
Edit: Seemed like a temporary glitch. The file is there and I could download it

@zonkmachine
Copy link
Member

I see a difference between RC6 and RC7 with this file. I'll try to bisect this.

@PhysSong
Copy link
Member

PhysSong commented Dec 7, 2018

Isn't this #3451?

@musikBear
Copy link
Author

Isn't this #3451?

at least very similar, but the 3451 need to be expanded to be valid for even saving and reopening. In fact if export has taken place after reopening the project, then this bug is the reason for 3451
I wish i had a project from 1.1.3 where i had manipulated pitch, and could test how that project would load in rc7, but i dont
How is rc6 different?
..Its a rather bad bug, because it changes output of project, with saved pitch-changes ( afaik only in zasfx -i tested 3oc. That was not bugged. I need to test Vestige and SF. 303 is also 'different' from std ..patman too)

@musikBear
Copy link
Author

@PhysSong
Sadly the bug is in Vestige too

@tresf
Copy link
Member

tresf commented Mar 9, 2019

Is there a chance this was fixed by f37ca49?

@tresf tresf added the response required A response from OP is required or the issue is closed automatically within 14 days. label Mar 9, 2019
@musikBear
Copy link
Author

is f37ca49 in RC8?
RC8 win32 still have the bug, and with same behavior, tested with the test-file above, with was created on RC7.
There for a made a new RC8 testfile but added a VST too
Unfortunately the bug persists for both zasfx and vst, so if f37ca49 is in RC8, it diddent help

@no-response no-response bot removed the response required A response from OP is required or the issue is closed automatically within 14 days. label Mar 11, 2019
@tresf
Copy link
Member

tresf commented Mar 11, 2019

@musikBear thanks. No, this is still a problem and yes, I believe it to be the same code as #3451. I'm merging the two and marking for stable.

@tresf tresf closed this as completed Mar 11, 2019
@tresf
Copy link
Member

tresf commented Mar 11, 2019

It looks like the pitch isn't properly communicated when loading a project, either.

@softrabbit wrote this two years ago in #3451, btw.

@tresf
Copy link
Member

tresf commented Mar 11, 2019

Fixed in 04768ee. @musikBear the next Windows build will have this issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants