Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Track - Effect Chain Window - Add Title and Remove The Fullscreen Icon #3268

Closed
miketurn opened this issue Jan 16, 2017 · 5 comments
Closed

Comments

@miketurn
Copy link
Contributor

miketurn commented Jan 16, 2017

Means nothing to me, but something I noticed.

If you click on a "sample track"s label it will open up an "effects chain" window for it.
1.) Might be a good idea to add the sample tracks name as a title for this effects window to know what sample track it is linked to. (Might be tough due to the width of the effects chain, probably why it is not there)
2.) This "effects chain" window also contains a maximize/fullscreen icon to the left of its "x" close icon in the titlebar, which should probably be removed.

@BaraMGB
Copy link
Contributor

BaraMGB commented Jan 16, 2017

👍

@BaraMGB
Copy link
Contributor

BaraMGB commented Jan 23, 2017

Perhaps we should add the ability for adding the sample track to an fx channel and get rid of this ugly effect window?

@tresf
Copy link
Member

tresf commented Jan 23, 2017

The effect window is only ugly because the instrument is otherwise and empty screen.

If the standard instrument controls (volume, pan, envelope, FX, LFO, pitch) are desired, keep the window, else delete. :)

@PhysSong
Copy link
Member

#3632 should fix this. 👍

@DomClark
Copy link
Member

DomClark commented Jul 1, 2020

Fixed in #3866.

@DomClark DomClark closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants