Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a file should not corrupt existing files when disk is full #26

Closed
eagles051387 opened this issue Jan 15, 2014 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@eagles051387
Copy link

I save my project files to a Samba file share. Without my awareness of the shared disk being full, I overwrote a previously existing project file in LMMS without any error or warning. LMMS wrote to a file of 0KB in size and the mistake was not made known to me until later when I tried to reload the project again in LMMS.
pgib in irc suggested I write a ticket for this issue, regarding file saving errors, such as the above. I hope pgib won't mind me pasting their words here.
"10:54 <+pgib> That is a defect though: LMMS shouldn't write a 0-sized file without warning. and it definitely shouldn't overwrite an old file until the new one is committed to disk (atomic write)
...
11:48 <+pgib> Something along the lines of: Saving to a file should not corrupt existing files (save to a temporary file, then rename). Additionally, any error to create the new file should result in an error message with the ability to save to a different filesystem."

kriskropd: I made a mistake in the ticket description and I don't know how to edit the original. I mistakenly said that I did not receive an error when overwriting a file in LMMS. I did receive a warning indicating the filename already existed. What I meant was there was no error or warning that the disk was full and that the file would be corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants