Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra flat theme #2590

Closed
IvanMaldonado opened this issue Feb 19, 2016 · 5 comments
Closed

Extra flat theme #2590

IvanMaldonado opened this issue Feb 19, 2016 · 5 comments

Comments

@IvanMaldonado
Copy link
Contributor

Now that we are at it...

I would like to propose another theme for the LMMS as an 'extra' for the people (who like me) like flat designs without gradients (pretty much what google has been doing lately).

This is the theme I am using as a reference:

x8l8e7c

And this is my current progress:

current

I still have to work with the new gradient-free possibilities made possible via
7d874fc and 2869d53

I will also change some graphics (like the knobs and other things that doesn't match very well)

I hope I'll have your support guys, thank you for the new possibilities provided!

@rubiefawn
Copy link
Contributor

<3 would use.

@tresf
Copy link
Member

tresf commented Feb 19, 2016

@IvanMaldonado we appreciate your hard work, but we don't usually open a new bug report for each theme proposal, we have LSP for that.

In the case of the #2587 theme, this theme has been planned and coordinated by several developers over the course of almost 2 years, which is why it is a good candidate and why it doesn't come as a surprised proposal. Furthermore, we don't yet have a theme-switcher, and even if we did, we can't maintain too many themes at once.

I'll kindly ask that you help us with the #2587 effort for now and we encourage you to share your theme though whatever means necessary. We're not entertaining bundling other themes at this time, sorry.

@tresf tresf closed this as completed Feb 19, 2016
@IvanMaldonado
Copy link
Contributor Author

It's a shame, I just want to clarify that the only reason I made this is because I thought other people would like to have an extra theme, just like the classic theme will also be there. If you feel there can't be other themes incluided with the standard install, I respect that. 👍

I was thinking that maybe some themes from the LSP from other designers would also be well accepted by the community, since not many LMMS users know about the LSP and not everyone enter the forum. Most of the people I have known in other forums say that one of the main reasons they don't use LMMS that often is because of the look, I was thinking that maybe adding more than one look, could satisfy a bigger group of people but this is just my idea, I know there are a lot of other more important things that must be worked on.

I accept what you say and maybe I was too impatient to change the look of LMMS (the issues I open are all about the look).

Just one question: what did you mean with this?

we can't maintain too many themes at once.

@tresf
Copy link
Member

tresf commented Feb 19, 2016

Just one question: what did you mean with this?

we can't maintain too many themes at once.

Once we accept a theme into our codebase, we need to maintain it. This means if a class in our codebase changes from sf2Instrument to Sf2Instrument, we have to modify it in every theme we bundle.

If our code was a bit more stable from a namespace perspective, this wouldn't be an issue, but as long as it is NOT (and it will continue to be unstable for a few more years), we have to do what's necessary to ship with sane defaults and not kill our development team with theme maintenance. This is already a struggle for languages because changing text can affect so many source files.

Even the idea of shipping both Noir and Classic (for lack of better names) is a difficult decision. We may pull Classic at the last minute out of our code to prevent this same issue (although both are feature-complete for the 1.2 release, so we'll see how that goes). And we still don't have a theme-switcher, so it's hard to make an argument for a 2nd theme if we don't give the user the ability to switch it... i digress. ;)

What I think many people would like is the ability to quickly switch between dark/lite themes, which we may eventually offer support for, but even QtCreator struggles with that, so even dark/lite support is not a trivial task.

-Tres

@RebeccaDeField
Copy link
Contributor

@IvanMaldonado I sent you an email with some resources for a flat theme :)

Also, you were saying that not many people know about the LSP. Maybe we can add something about this on the download page for LMMS so that people can be more aware of the other themes available?

My 2 cents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants