Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No preview for beat/bassline #1263

Closed
liftarn opened this issue Nov 3, 2014 · 16 comments
Closed

No preview for beat/bassline #1263

liftarn opened this issue Nov 3, 2014 · 16 comments

Comments

@liftarn
Copy link

liftarn commented Nov 3, 2014

Both piano rolls and sample tracks have previews, but not the beat/bassline.

Example: http://lmms.sourceforge.net/screenshots/1.0.0/lmms-1.0.0-1.png

@mikobuntu
Copy link
Contributor

I'm sure this could be possible to implement by one of the devs, But i'm not sure it is necessary and it may make it hard to distinguish between song tracks and bb_tracks in the song_editor.

  • hint: you might want to crop your original image to show just the part you are describing and perhaps use gimp or some app to highlight and document your thoughts .... example below :

thanks Mikobuntu ;)

@tresf
Copy link
Member

tresf commented Nov 3, 2014

I'd like to see a mock-up of what you would like this to look like. That blue bar is quite the small amount of real-estate for a BBEditor preview. If you could illustrate how you'd like this to be visualized, perhaps we could speak to the feasibility of it.

@Umcaruje
Copy link
Member

Umcaruje commented Nov 3, 2014

The problem IMO is that B&B lines can be severely complex (I usually have 20+ instruments in a B&B and some are patterns, some are notes ) So actually I can't really see this working. Even if you could visualize all the patterns, it'd get too crowded and would become ugly.

@tresf
Copy link
Member

tresf commented Nov 3, 2014

The problem IMO is that B&B lines can be severely complex (I usually have 20+ instruments in a B&B and some are patterns, some are notes ) So actually I can't really see this working. Even if you could visualize all the patterns, it'd get too crowded and would become ugly.

I share the same opinion here, which is why I'd like the OP to explain what he wants. If he can't visualize this happening, then we'll have to invalidate this bug, since we can't do the impossible! 👍

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 3, 2014

Pgib has code for it. It is just a matter of making it fit in the new LMMS. I think dizzy and pgib agreed to wait for it after the theming rehaul was finished

@tresf
Copy link
Member

tresf commented Nov 3, 2014

Pgib has code for it.

Interesting. Do we have a screenshot somewhere? If it has already been started, we should probably mark a milestone for it, no?

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 3, 2014

yeah, there are lying a screenshot here on github if I aren't mistaken, one of the first threads here on github. I'll update my comment if I find it.
UPDATE: #150 Ooh, it was probably the picture of Cusis theme, and of course it is for the old LMMS, if many things have happened after that...

@liftarn
Copy link
Author

liftarn commented Nov 4, 2014

lmms-1 0 0-1
Not much of an artist, but I was thinking something like this. Just as piano roll is a representation of notes this is a representation of drum notes. One mark for each active beat and different drums on different heights.

@Umcaruje
Copy link
Member

Umcaruje commented Nov 4, 2014

Not much of an artist, but I was thinking something like this. Just as piano roll is a representation of notes this is a representation of drum notes. One mark for each active beat and different drums on different heights.

What if there is a pattern that looks like this?

visualise this

Note that this is a mildly complex pattern.

I also think that B&B patterns would get too close looking to instrument patterns if we do this.

@liftarn
Copy link
Author

liftarn commented Nov 4, 2014

lmms-1 0 0-1
Yes, complex pattern would looks more complex.

@diizy
Copy link
Contributor

diizy commented Nov 4, 2014

On 11/04/2014 11:45 PM, Umcaruje wrote:

Not much of an artist, but I was thinking something like this.
Just as piano roll is a representation of notes this is a
representation of drum notes. One mark for each active beat and
different drums on different heights.

What if there is a pattern that looks like this?

It wouldn't be any different from how we represent instrument patterns
that have lots of stacked notes.

I also think that B&B patterns would get too close looking to
instrument patterns if we do this.

That's a possible concern, sure.

@mikobuntu
Copy link
Contributor

Imo this looks like it could be very useful actually and the graphic is aesthetically pleasing too ( won't clash with the instrument midi note preview ) . +1 from me

thanks Mikobuntu ;)

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 4, 2014

Great idea! Look at the dots here for example, brilliant http://cusis.deviantart.com/art/CUSIS-User-Interface-LMMS-136994117
It depends on how one design it if they'll be hard to differ from instrument tracks in the Song Editor. have plenty of ideas:

  • So Cusis thought about B&B patterns like drums only, and if B&B patterns only are represented by circular dots it would be easy to differ them apart from instrument segments/clips/patterns. This can be done even with instruments, the different tracks can be drawn on different lines. Notes for instruments would look mono.
  • B&B mixes both instruments and steps/patterns, so dividing the area in two, the upper dedicated for drum beats and the latter for instruments for example, could be something. You could even be so advanced to use the function LMMS has If one doesn't put all basslines and
  • Both instrument notes and drum notes on top of each other!! Some transparent magic or blend modes (expression taken from GIMP)?
  • My personal favorite: Make use of the function LMMS has to expand the height of the tracks in the Song Editor and let the user choose how much of the B&B tracks she want's to see. This will make it possible to show practically the whole B&B Editor in a segment/pattern/clip in the Song Editor.
  • Option to choose which instruments to draw and only allow drumsteps or song notes and not a mix?

@Spekular
Copy link
Member

Spekular commented Nov 5, 2014

I was thinking that we could represent everything as a hit. Pretend all the
notes are the same note and then represent them as
squares/triangles/circles/vertical lines (I kinda like vertical lines as it
would differentiate them from notes and make them more visible than a dot)

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 5, 2014

Depends on how you picture a dot

@tresf
Copy link
Member

tresf commented Mar 8, 2015

Marking as duplicate of the "Cusis Theme" effort #1839 and closing to consolidate bug reports.

@tresf tresf closed this as completed Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants