Enhancement: Get option to custom color instruments tracks like beat and bass tracks

[antoniorodc]

Get the possibilty to change and customize color of individual instruments tracks. This feature must be easy to code because already run in beat&bass tracks.

[tresf]

This feature must be easy to code

Please do, it is open source. 🍺

[antoniorodc]

Sorry but I don't program in C++ :-/

[diizy]

Nothing is easy in C++ :-\

[StakeoutPunch]

Still a useful thing for themers, setting the default color for them.

[antoniorodc]

I refer to custom by user not by theme. Like it works in tracks beat&bass in 1.0.95

[Sti2nd]

The user make the themes. We are all users @antoniorodc So if you want pink color on all the instrument tracks, you can decide this in the CSS file in the theme you are using. I agree that it could be useful to be able to color the instrument segments in addition to the B&B blocks for structuring. For now you must use the ability to name the segments for structuring

[diizy]

I'm again not very fond of the idea of having user-definable colours for
other track types.

The problem is that we have themes, and the user-definable colours may
not work with all theme settings. Say you use a theme with a very dark
background in the song editor, but then you open a project file made by
someone else who's used a very light song editor background, and has
coloured all patterns with dark colours. Now it's hard for you to see
the patterns.

This problem would need to be solved before I'd be comfortable with the
idea of enabling user-definable colours for other track types. This has
been discussed before.

[Sti2nd]

Quote diizy: "TODO: add a settings option that can disable custom colours (ie. always use style colour), and/or an option to reset all patterns in a project to style colour. This is needed, since themes can now change the song editor background, which can lead to unfortunate colour combinations with custom colours..." #817

[musikBear]

This problem would need to be solved before I'd be comfortable with the idea of enabling user-definable colours for other track types. This has been discussed before.
like here #560, but i believe we had a long thread in devel oround colors as well (il link if i find it)
But since changing colors would be 'voluntary' 👻 -why not let users decide if they prefere a sleek visual apealing interface, or an informative color-coded workspace ?
I (once again) do not understand the theme issue as a blok for customizing the interface.
That goes for mixer-channels too, btw

[diizy]

On 09/14/2014 03:13 PM, musikBear wrote:

But since changing colors would be 'voluntary' :ghost: -why not
let /users/ decide

Because sometimes you may have to open project files made by other people?

"Let the users decide" is not the ultimate answer to everything...

[tresf]

Or the theme provides a limited list of compatible colors, to the likes of
many other DAWs which provide this feature although like I've said before,
calculating incompatible color tints/shades combinations and automatically
adjusting works pretty well too. :)

[StakeoutPunch]

@diizy Why is that even a problem? So what if the patterns are dark? We can't all have OCD, and just because one person does doesn't mean that wanted functionality should be ignored.

Clarification, as needed: My use of the term OCD was not to be insulting to those with an actual diagnosis, but as a blanket term for whoever may trivially (or by mere opinions) be upset by something as frivolous and easily changed as theme colors. It was not within my intentions to reference or use a real medical condition to call out or shame those with it.

Say you use a theme with a very dark
background in the song editor, but then you open a project file made by
someone else who's used a very light song editor background, and has
coloured all patterns with dark colours. Now it's hard for you to see
the patterns.

For the record, I use a completely blacked out theme. Black on black or dark gray is the basis of it, because I happen to not like the neon contrast in the new theme. My song editor background is black and gray, and my clips are black as well. Recognize that others have extremely varied opinions. Trying to plan for all scenarios is not a time worthy thing to do, as you can't address each one, and some issues are better left to the users anyway. A UI isn't going to kill anyone, and if it is that bad, they can spend the 10 minutes resetting the colors/ loading a theme that works.

@Sti2nd that idea works, but adding a right click option to just reset the clip color would work too.

[diizy]

On 09/14/2014 10:06 PM, StakeoutPunch wrote:

@diizy https://github.com/diizy Why is that even a problem? So what
if the patterns are dark? We can't all have OCD, and just because one
person does doesn't mean that wanted functionality should be ignored.

Ok, tell you what: feel free to fork LMMS, learn C++ and implement
whatever crazy idiotic functionality you want in your fork. The source
is open, no one is stopping you.

*Let me make myself perfectly clear here: I'm not your slave, I do this
as a hobby, for free, on my own time, and getting called "OCD" for my
troubles is not really encouraging me to serve your every stupid whim. *

[Sti2nd]

I think Diizy thought right in predicting stupid users. I can be really stupid at times, and others can certainly too. Too many traps can make LMMS a difficult labyrinth.

[diizy]

On 09/14/2014 10:23 PM, Stian Jørgensrud wrote:

Too many traps can make LMMS a difficult labyrinth.

Right, and this isn't even about not having the functionality. Just that
other functionality needs to also be implemented before it's safe to
implement this one.

[StakeoutPunch]

@diizy Last time I checked I never told you to do anything other than not shoot everything down because you don't like it. No one is stopping you from being nice.

And I've been and am still currently at a university so I can do just that, thank you very much for the suggestion.

To clarify, that OCD comment wasn't directed at you. It was at the users that may cry about a theme looking bad with certain colors on clips. Untwist.

Further clarification: My use of the term OCD was not to be insulting to those with an actual diagnosis, but as a blanket term for whoever may trivially (or by mere opinions) be upset by something as frivolous and easily changed as theme colors. It was not within my intentions to reference or use a real medical condition to call out or shame those with it.

[diizy]

Let me just remind everyone here - naming no names, pointing no fingers

• that partaking in these discussions is a privilege, not a right. If
  you can't act with some basic human decency, that privilege can also be
  taken away.

Ableist language, such as calling people things like "OCD" as if a
mental illness were an insult or something wrong in a person is also
not OK, it is not funny, and it is very insulting towards people who
actually struggle with such issues. Such things will not be tolerated.
If you can't abide by this, if you cannot behave with some common
courtesy towards your fellow human beings, then you're not welcome here,
plain and simple. Let's hope it doesn't have to come to that.

[tresf]

calling people things like "OCD" as if a mental illness were an insult or something wrong in a person is also not OK

If I said John Doe could benefit from a "c++ programming for dummies" manual, I should only hope that not be taken out of context and used as a slanderous remark against John Doe's intelligence.

We are all typing from different parts of the world with different personalities and different culture and we should be sensitive to that (from both directions). Regardless, SP went back and modified his original statement:

Clarification, as needed: My use of the term OCD was not to be insulting to those with an actual diagnosis, but as a blanket term for whoever may trivially (or by mere opinions) be upset by something as frivolous and easily changed as theme colors. It was not within my intentions to reference or use a real medical condition to call out or shame those with it.

Back on topic, I believe the points raised in this topic are for the most part very valid. The colors are a feature many would like, but theme compatibility considerations should be made carefully. Furthermore, unless someone new starts coding this feature, simply talking about it won't get us any further towards a solution. Coders wanted. ☕

[musikBear]

Please talk nicely -Dont haggle so much -diiz know the dependencies, so colors may be difficult, but i stick to my wish for colors, because it would make for easy structuring. We all have whishes, and udears for how lmms should be. Sometimes a little give in one direction, can be beneficial for all. Lets not loose focus, and lets not use bad language, inuendoes, and as like -> keep the 👪

[diizy]

On 09/15/2014 04:48 PM, Tres Finocchiaro wrote:

Regardless, SP went back and modified his original statement:

Clarification, as needed: My use of the term OCD was not to be
insulting to those with an actual diagnosis, but as a blanket term
for whoever may trivially (or by mere opinions) be upset by
something as frivolous and easily changed as theme colors.

Yeah no, that just doesn't cut it. Here's an example: say I go around
calling people with the n-word (you know the one). Then I explain that I
wasn't actually saying that to insult coloured people, but instead I was
just using the common racist stereotype about coloured people to
ridicule people who I think match those stereotypes... does that make
the use of a degrading racist slur ok? I don't think so.

A smart person would at this point, instead of doubling down and trying
to justify/rationalize their actions, apologize and say "I was wrong to
use that word, I did it without thinking, now I know better and won't do
it again". *
*
There's all kinds of people in the FOSS world, and we should strive to
be inclusive enough that we don't alienate anyone with judgemental or
prejudiced behaviour. This doesn't mean we have to walk on eggshells,
but some basic consideration for people's different life experiences
shouldn't be too much to ask.

[Sti2nd]

What I really wonder about, is. Do you feel LMMS 1.1.0 is ready for release now? @diizy

[tresf]

wasn't actually saying that to insult coloured people

Symantecs, but even that phrase has grown quite a bit of distaste in certain regions.

https://answers.yahoo.com/question/index?qid=20071210015205AA8J7XC
https://uk.answers.yahoo.com/question/index?qid=20101205034341AAX4s1Q

[StakeoutPunch]

It isn't about being smart, smart people aren't immune to rash decisions. Perhaps you are trying to say that someone with common sense wouldn't continue. You got me there, I've no common sense.

I could have been wiser in my word choice. I'll admit that. No arguing there.

However, you went completely overboard indirectly calling me an "indecent" human being for using such a label. Sure, you said no one in particular but it's pretty obvious you have been gunning straight at me this whole time, making me some sort of example. You say to have respect for fellow human beings, but say it in the most rude way possible. That is hypocrisy in its finest form. Practice what you preach. I'm done posting on this issue. I am not going to say another word, having apologized for my poor choice of wording.
.

[diizy]

On 09/15/2014 10:48 PM, StakeoutPunch wrote:

I could have been wiser in my word choice. I'll admit that. No arguing
there.

Cool. Apology accepted and I'm sorry if I made the point a bit too
sharply. This argument is over and forgotten as far as I'm concerned.

[diizy]

On 09/15/2014 09:08 PM, Stian Jørgensrud wrote:

What I really wonder about, is. Do you feel LMMS 1.1.0 is ready for
release now? @diizy https://github.com/diizy

I'll have to test the Carla branch, and if everything looks ok there,
I'll merge that before releasing 1.1.

[Sti2nd]

@diizy Tested and merged?

[Spekular]

@tresf to be consolidated into #1665 as this has to do with user definable colors.

[tresf]

This bug report has been consolidated (at least for now) into a placeholder #1665 for better color handling in general. Feel free to update this bug report or the parent bug as needed.

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

[tresf]

Done via #5573