Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of exit codes to check if things are behaving as expected #24

Open
Kurolox opened this issue Oct 2, 2017 · 0 comments
Open
Assignees

Comments

@Kurolox
Copy link
Owner

Kurolox commented Oct 2, 2017

Right now the bot depends only on the stdout and stderr to know if things went well (if there's any output while compiling, the bot will assume that there was a problem and it will return the compiler output without executing the binary, even if it was just a warning.)

Adding support for checking the exit code of the subprocess would improve the bot and make it more flexible.

@Kurolox Kurolox self-assigned this Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant