Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate HydraDX swap SDK #2758

Closed
nampc1 opened this issue Mar 16, 2024 · 7 comments · Fixed by #2770
Closed

Integrate HydraDX swap SDK #2758

nampc1 opened this issue Mar 16, 2024 · 7 comments · Fixed by #2770
Assignees
Milestone

Comments

@nampc1
Copy link

nampc1 commented Mar 16, 2024

No description provided.

@nampc1 nampc1 self-assigned this Mar 16, 2024
@nampc1 nampc1 added this to the Milestone 7 milestone Mar 16, 2024
@nampc1 nampc1 linked a pull request Mar 29, 2024 that will close this issue
@nampc1
Copy link
Author

nampc1 commented Mar 30, 2024

  • DOT <-> HDX
  • DED <-> DOT
  • USDT <-> DOT

@nampc1
Copy link
Author

nampc1 commented Apr 1, 2024

  • Allow slippage change when quote is from HydraDX
    • Options are 0.1, 0.5, 1, 3%
    • Slippage will be 1% be default
  • Add the swap provider logo for HydraDX
  • Fetch latest quote after each submission step

@Sokol142196
Copy link

Sokol142196 commented Apr 3, 2024

UI bugs

  • Do not update "Estimated received" on the Swap quote screen after reset quote

    • Actual: Still show "Estimated received" on the first time
    • Expect:
      • Reset "Estimated received" when reset quote
      • Update and show the "Estimated received" of each Swap quote
        image
  • Update UI for Slippage
    image
    image

  • (!) Review and re-test responsive

  • (!) Show more token and token info if XCM available

    • Expect:
      • Show symbol token and network (Example: DOT (HydraDX))
      • Shows tokens ready for XCM transfer on Available balance field
  • (!) Add message on Swap input screen

    • Expect: If the token supports XCM operations and is XCM qualified, display this message
      • Header: Action needed
      • Message: The amount you entered is higher than your available balance on X network. You need to first transfer cross-chain from Y network to X network to continue swapping
      • Type message: warning
  • (!) Add message on the Swap confirmation screen in case reset quote when Swap with XCM transfer

    • Header: Pay attention!
    • Message: The swap quote has been updated. Make sure to double-check all information before confirming the transaction.
    • Type message: warning
    • Notes: If user standing on Swap confirmation screen and swap quote expired then only show Swap quote expired message
  • (!) Ui bugs

  • (!) Handle case Slippage

    • If provider = ChainFlip then show default slippage = 0 and do not allow edit slippage
    • If provider = HydraDX then show default slippage = 1 and allow edit slippage
  • UI bugs when the number is very small
    image

  • Handle case XCM flow


Logic bugs

  • Re-check pair DOT --> DED

    • If not support then hide DED token
  • Bug Cannot read properties of undefined (reading 'type') when swap

    • Popular with USDT, sometimes seen on DOT (HydraDX)
      image
      image
  • Re-check validate amount in case Available = 0

    • Expect: Show message ""
      image
      image
  • Re-check validate in case Available = ED
    -Expect: Show message ""
    image

@Sokol142196
Copy link

Sokol142196 commented Apr 3, 2024

Improve

  • Update history details screen

    • If Origin chain same as Destination chain then only show only 1 field "Network"
    • Else show "Origin network" and "Destination network"
      image
  • Update the Swap confirmation screen

    • If wait time > 0 then show warning
    • Else then hide warning
      image

@haiyenvu23
Copy link

haiyenvu23 commented Apr 8, 2024

Version test : https://9b143512.subwallet-webapp.pages.dev/
Improve responsive

  • Update padding : "16px 24px"

Image

  • Font-size title popup Terms of service : "20px" -> "24px"

Image

  • When minium long

Image

  • UI bug

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Apr 9, 2024

@dungnguyen-art Please fix:

  • Show incorrect Minimum received for Chainflip
    image

  • Add account recipient on confirmation screen

    image

@Sokol142196
Copy link

Improve in #2780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants