Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated test ensuring ResolveDependencies is implemented for all supported object types #6026

Closed
Tracked by #5854
czeslavo opened this issue May 15, 2024 · 1 comment
Assignees
Labels
release/required it is required that this be resolved before releasing
Milestone

Comments

@czeslavo
Copy link
Contributor

czeslavo commented May 15, 2024

We should have an automated test that will ensure that all object types store.CacheStores keeps have an explicit switch-case defined in fallback.ResolveDependencies function.

Proposed solution

Rework store.CacheStores and its methods (Get, Add, Delete) to be wholly generated, enforcing a single point of truth for what object kinds it supports. This will allow adding one more "meta" method: SupportedObjectTypes that we will be able to use in the ResolveDependencies test to ensure we have a switch case for every supported type explicitly defined (if there's no case defined, ResolveDependencies should return an error).

@czeslavo
Copy link
Contributor Author

Done in #6010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/required it is required that this be resolved before releasing
Projects
None yet
Development

No branches or pull requests

1 participant