Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KongUpstreamPolicy CRD validation rules #4951

Closed
7 tasks done
Tracked by #3174
czeslavo opened this issue Oct 24, 2023 · 0 comments · Fixed by #4955
Closed
7 tasks done
Tracked by #3174

Add KongUpstreamPolicy CRD validation rules #4951

czeslavo opened this issue Oct 24, 2023 · 0 comments · Fixed by #4955
Assignees
@czeslavo
Labels
area/feature New feature or request
Milestone
KIC v3.0.x

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Oct 24, 2023 •
edited
Loading

Add CEL validation rules to KongUpstreamPolicy CRD and cover them with tests:

  • At most 1 of spec.hashOn.(cookie|header|uriCapture|queryArg) fields can be set
  • At most 1 of spec.hashFallback.(header|uriCapture|queryArg) fields can be set
  • spec.hashOn.cookiePath is required when spec.hashOn.cookie is set
  • spec.hashOn.cookiePath must not be set when spec.hashOn.cookie is not set
  • spec.hashFallback.(cookie|cookiePath) must not be set
  • healthchecks.(passive|active).healthy.http_statuses entries must be in [100-599] range
  • healthchecks.(passive|active).unhealthy.http_statuses entries must be in [100-599] range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czeslavo czeslavo

Labels
area/feature New feature or request
Projects
None yet
Milestone
KIC v3.0.x
Development

Successfully merging a pull request may close this issue.

feat: add KongUpstreamPolicy CRD validation rules Kong/kubernetes-ingress-controller
1 participant
@czeslavo