Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate KongIngress CRD entirely #4720

Closed
5 of 6 tasks
programmer04 opened this issue Sep 25, 2023 · 3 comments
Closed
5 of 6 tasks

Deprecate KongIngress CRD entirely #4720

programmer04 opened this issue Sep 25, 2023 · 3 comments
Assignees
Labels
area/CRD Changes in existing CRDs or introduction of new ones breaking change
Milestone

Comments

@programmer04
Copy link
Member

programmer04 commented Sep 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Standard Ingress and gateway-api are feature reach enough to express everything, thus KongIngress can be entirely deprecated.

Proposed Solution

No response

Additional information

Required to be resolved/resolves/obsoletes:

Acceptance Criteria

  • KongIngress.(Service|Route) fields are not allowed to be set
  • KongIngress.Upstream field is deprecated (a warning is returned from the admission webhook)
@programmer04 programmer04 added breaking change area/CRD Changes in existing CRDs or introduction of new ones labels Sep 25, 2023
@programmer04 programmer04 added this to the KIC v3.0.0 milestone Sep 25, 2023
@mflendrich
Copy link
Contributor

Blocked by the issues mentioned in

Required to be resolved/resolves/obsoletes

@czeslavo czeslavo self-assigned this Oct 27, 2023
@czeslavo
Copy link
Contributor

@mheap Is this still valid that we want to remove KongIngress in KIC 3.0 completely? KongIngress.Upstream hasn't been deprecated and dropping that might be unexpected for users. We only had it being planned in the Using KongIngress guide:

The upstream section of KongIngress will be replaced with a new resource, but this is still in development and upstream is not officially deprecated yet.

@czeslavo
Copy link
Contributor

After a short discussion I've updated the ACs to reflect what we want to actually achieve by resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants