Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Feature Request> Provide a means to add global plugin configurations #109

Closed
rainest opened this issue Aug 29, 2018 · 2 comments
Closed
Assignees
Labels
area/feature New feature or request

Comments

@rainest
Copy link
Contributor

rainest commented Aug 29, 2018

Summary

Provide a means to configure plugins globally.
Not implemented as of Kong Ingress controller version 0.1.0, the current latest version.
Not specific to K8S version or platform.

Background

Kong can add plugins globally that then apply to any request that does not match a more specific plugin configuration.

At present, the KongPlugin object does not provide any means to configure global plugins, and it is not possible to configure them via Ingress metadata, as all Ingress objects must apply to specific routes.

Implementation considerations

  • KongPlugin will need an annotation to specify that the plugin should be applied globally, similar to consumerRef for applying on a per-consumer basis. global: true or similar would work.
  • Conflicting or ambiguous configuration (e.g. setting both global: true and consumerRef: yoda on the same KongPlugin) must be handled in some way. The IC could either reject this configuration and return an error when attempting to create the object, or it could attempt to infer the user's intent (creating both a global and consumer-specific plugin configuration with the same settings).
@rainest rainest added the area/feature New feature or request label Aug 29, 2018
@hbagdi
Copy link
Member

hbagdi commented Aug 31, 2018

This will be possible with #112.

@hbagdi
Copy link
Member

hbagdi commented Sep 10, 2018

Hello @rainest,

#112 just got merged into master. This will be available in our next release. Documentation will be updated before the release process. Thanks!

@hbagdi hbagdi closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants