We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, colleagues.
Looking in the code, i see, the FromZigbee the sensor values is returned as a string:
case common.TuyaDataPoints.moesSensor: switch (value) { case 0: return {sensor: 'IN'}; case 1: return {sensor: 'AL'}; case 2: return {sensor: 'OU'}; default: return {sensor: 'Not supported'}; }
But in ToZigbee it uses a numerik values:
// send an mqtt message to topic '/sensor' to change the temperature sensor setting - options [0=IN|1=AL|2=OU] moes_thermostat_sensor: { key: ['sensor'], convertSet: async (entity, key, value, meta) => { await sendTuyaDataPointEnum(entity, common.TuyaDataPoints.moesSensor, value); }, },
what is version is right? I'm ready to prepare a PR, but what it better ? By my understanding - it have to be identical type of values for in and out
The text was updated successfully, but these errors were encountered:
String is preferred here, but to avoid a breaking change allow both numbers and strings in the toZigbee converter.
Sorry, something went wrong.
Done at PR
Successfully merging a pull request may close this issue.
Hello, colleagues.
Looking in the code, i see, the FromZigbee the sensor values is returned as a string:
But in ToZigbee it uses a numerik values:
what is version is right?
I'm ready to prepare a PR, but what it better ?
By my understanding - it have to be identical type of values for in and out
The text was updated successfully, but these errors were encountered: