Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All items should be set when creating/modyfing profile #4

Closed
qarmin opened this issue Mar 10, 2024 · 2 comments · Fixed by #13
Closed

All items should be set when creating/modyfing profile #4

qarmin opened this issue Mar 10, 2024 · 2 comments · Fixed by #13

Comments

@qarmin
Copy link

qarmin commented Mar 10, 2024

When creating new profile, after selecting "FastCompile" template, only some of properties are filled and rest probably uses some default values.

The problem is that I don't know which properties are default, so I still need read https://doc.rust-lang.org/cargo/reference/profiles.html, but this project aims to avoid this

Screenshot from 2024-03-10 20-57-51

@Kobzol
Copy link
Owner

Kobzol commented Mar 10, 2024

Hi! That's a good point. I suppose that I assumed that FastCompile will be mostly applied to the dev profile, but it doesn't have to be, of course. I guess that each template should contain the defaults from its "base" profile (FastCompile from dev and the remaining two from release). This should be a rather easy change to be made here, do you want to send a PR? :) If not, I'll fix it.

@Kobzol
Copy link
Owner

Kobzol commented Mar 11, 2024

#13 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants