Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please never forget increasing versionCode for new releases #2

Closed
IzzySoft opened this issue Sep 2, 2024 · 7 comments
Closed

Please never forget increasing versionCode for new releases #2

IzzySoft opened this issue Sep 2, 2024 · 7 comments

Comments

@IzzySoft
Copy link

IzzySoft commented Sep 2, 2024

Unfortunately your hotfix release will reach no existing installation as you seem to have forgotten increasing versionCode:

Binary files repo/com.kip.reykunyutsyip_3.apk and repo/com.kip.reykunyutsyip_1.3.5.apk differ

That means the already existing version also had versionCode: 3. There are 5 releases listed, which means it should have been at least versionCode: 5 by now 😉

@IzzySoft
Copy link
Author

IzzySoft commented Sep 2, 2024

Oh, PS, while I'm here:

! repo/com.kip.reykunyutsyip_3.apk contains signature block blobs: 0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

That can easily be avoided with a tiny addition to your build.gradle:

android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains. More details can be found e.g. here: Ramping up security: additional APK checks are in place with the IzzyOnDroid repo.

Thanks in advance!

@KipJM
Copy link
Owner

KipJM commented Sep 3, 2024

Hiya! Thanks for pointing that out! I have fixed the build and have removed the Google dependency blob
Commit: 88df0cb
thanks again!

@KipJM KipJM closed this as completed Sep 3, 2024
@IzzySoft
Copy link
Author

IzzySoft commented Sep 3, 2024

Thanks! That worked out fine:

 iod repo get com.kip.reykunyutsyip
com.kip.reykunyutsyip: looking for 'https://api.github.com/repos/KipJM/Reykunyutsyip/releases'
com.kip.reykunyutsyip: checking tag '1.3.5'
com.kip.reykunyutsyip: lastRelNo set to '1.3.5', checking for files
com.kip.reykunyutsyip: Upstream file date (2024-09-03 02:39) is newer than ours (2024-09-02 18:06).
com.kip.reykunyutsyip: returning ['1.3.5','https://github.com/KipJM/Reykunyutsyip/releases/download/1.3.5/reykunyutsyip-1-3-5-fixed.apk',1725323970]
com.kip.reykunyutsyip: 1.3.0/1.3.5, https://github.com/KipJM/Reykunyutsyip/releases: https://github.com/KipJM/Reykunyutsyip/releases/download/1.3.5/reykunyutsyip-1-3-5-fixed.apk
- Grabbing update for com.kip.reykunyutsyip: OK
- Checking 'repo/com.kip.reykunyutsyip_5.apk' for libraries and malware …
- Checking the app's AndroidManifest.xml …
com.kip.reykunyutsyip: check if repo contains FUNDING.yml
com.kip.reykunyutsyip: looking for 'https://api.github.com/repos/KipJM/Reykunyutsyip/contents/.github'
com.kip.reykunyutsyip: looking for 'https://api.github.com/repos/KipJM/Reykunyutsyip/contents/'
com.kip.reykunyutsyip: looking for 'https://api.github.com/repos/KipJM/.github/contents/'
com.kip.reykunyutsyip: Github reports "Not Found" for https://api.github.com/repos/KipJM/.github/contents/
com.kip.reykunyutsyip: no FUNDING.yml detected.
com.kip.reykunyutsyip: no Fastlane configured, skipping Fastlane check.

So this update will become available here with the next sync around 6 pm UTC. Oh: be welcome to pick a badge and link there e.g. from your Readme if you wish 😉

@KipJM
Copy link
Owner

KipJM commented Sep 3, 2024

thanks! I sure will! :)

@KipJM
Copy link
Owner

KipJM commented Sep 3, 2024

Hi! I just want to clarify that the only data the app downloads is from the domain reykunyu.lu, which has its source code in the github link mentioned in the readme. It does not download any data from github (as I know of)
None of the data(dictionary, art, audio) is owned by me, they are all downloaded from Reykunyu. While the app and Reykunyu (and probably others) is allowed to download and use these data and art. While the dictionary data is using the CC license, the art and audio are copyright to their artists, they are not owned by either me or the Reykunyu website.

@IzzySoft
Copy link
Author

IzzySoft commented Sep 3, 2024

Thanks also for the notes! Updated that accordingly (effective with the next sync). Quite mixed stuff: libre, but also NC or maybe even proprietary content according to the "credits" on the site, so I've left it with NonFreeNet still but just replaced Gitub with reykunyu.lu in the description.

Thanks for adding the badge to your Readme 🤩

@KipJM
Copy link
Owner

KipJM commented Sep 3, 2024

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants