From fcf3324dea52b72706f1877cac113f6cb1adf78b Mon Sep 17 00:00:00 2001 From: Anakaren Rojas Date: Tue, 14 Jan 2025 15:35:56 -0800 Subject: [PATCH 01/10] update x coordinate to include pi readings --- .../interactive-graphs/graphs/sinusoid.tsx | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/perseus/src/widgets/interactive-graphs/graphs/sinusoid.tsx b/packages/perseus/src/widgets/interactive-graphs/graphs/sinusoid.tsx index 8484ba7239..5ca44215eb 100644 --- a/packages/perseus/src/widgets/interactive-graphs/graphs/sinusoid.tsx +++ b/packages/perseus/src/widgets/interactive-graphs/graphs/sinusoid.tsx @@ -67,9 +67,21 @@ function SinusoidGraph(props: SinusoidGraphProps) { index: number, coordinate: vec.Vector2, ): string { + const x = coordinate[0]; + const y = coordinate[1]; + + const convertedXCoordinate = + x === 0 + ? `0` + : x % 2 === 0 + ? `${x / 2} pi` + : x % 1 === 0 + ? `${x}/2 pi` + : `${x * 2}/4 pi`; + const coordsObj = { - x: srFormatNumber(coordinate[0], locale), - y: srFormatNumber(coordinate[1], locale), + x: convertedXCoordinate, + y: srFormatNumber(y, locale), }; return index === 1 From 040aa5807ddada9ad01a35a36b5813f3d27defdf Mon Sep 17 00:00:00 2001 From: Anakaren Rojas Date: Wed, 15 Jan 2025 10:33:33 -0800 Subject: [PATCH 02/10] update snapshots --- .../__snapshots__/explanation.test.ts.snap | 8 ++++---- .../__snapshots__/graded-group-set-jipt.test.ts.snap | 12 ++++++------ .../__snapshots__/graded-group-set.test.ts.snap | 4 ++-- .../__snapshots__/graded-group.test.ts.snap | 4 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/perseus/src/widgets/explanation/__snapshots__/explanation.test.ts.snap b/packages/perseus/src/widgets/explanation/__snapshots__/explanation.test.ts.snap index e96e0672b6..3383f7cfa0 100644 --- a/packages/perseus/src/widgets/explanation/__snapshots__/explanation.test.ts.snap +++ b/packages/perseus/src/widgets/explanation/__snapshots__/explanation.test.ts.snap @@ -21,12 +21,12 @@ exports[`Explanation should snapshot when expanded: expanded 1`] = ` aria-controls=":r1:" aria-disabled="false" aria-expanded="true" - class="button_vr44p2-o_O-shared_lwskrm-o_O-default_qjb97o-o_O-small_14crccx-o_O-inlineStyles_1s8anjv" + class="button_vr44p2-o_O-shared_lwskrm-o_O-default_1hl5pu8-o_O-small_14crccx-o_O-inlineStyles_1s8anjv" role="button" type="button" > Hide explanation! @@ -94,12 +94,12 @@ exports[`Explanation should snapshot: initial render 1`] = ` aria-controls=":r0:" aria-disabled="false" aria-expanded="false" - class="button_vr44p2-o_O-shared_lwskrm-o_O-default_qjb97o-o_O-small_14crccx-o_O-inlineStyles_1s8anjv" + class="button_vr44p2-o_O-shared_lwskrm-o_O-default_1hl5pu8-o_O-small_14crccx-o_O-inlineStyles_1s8anjv" role="button" type="button" > Explanation diff --git a/packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap b/packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap index fcf253b7dd..6d4b738751 100644 --- a/packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap +++ b/packages/perseus/src/widgets/graded-group-set/__snapshots__/graded-group-set-jipt.test.ts.snap @@ -251,12 +251,12 @@ exports[`graded-group-set should render all graded groups 1`] = ` />