Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicPage vs BasePage #95

Open
bogdan71 opened this issue Sep 13, 2021 · 1 comment
Open

BasicPage vs BasePage #95

bogdan71 opened this issue Sep 13, 2021 · 1 comment

Comments

@bogdan71
Copy link

Brief bug description

In the Developer 13 training course in namespace XperienceAdapter.Models you call the class BasePage, but here in github it is called BasicPage

What went wrong?
compilation error

I followed the code and ran into issue around cancellationToken within GetContentTreeNavigationAsync method

Error CS1744 Named argument 'cancellationToken' specifies a parameter for which a positional argument has already been given
Business\Repositories\NavigationRepository.cs

@JanLenoch
Copy link
Contributor

Hi @bogdan71 ,

Thanks for reporting the typo. It happened when I ditched the dual-rail strategy with conventional ASP.NET routing being implemented alongside the CTB router. During that refactoring, I also renamed the BasePage CLR type to BasicPage, which I forgot to rename in the course for some reason.

It is fixed by now.

As for your compiler error, I'm not sure what the root cause might be on your end. There are two overloads of that method and the client code calls them without specifying the names of the parameters. The client code relies on positional order. Therefore I'm afraid I won't be able to determine the cause. If you gave me further details, I'll be happy to help.

Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants