Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard for trusting external MFA is disabling instead of enabling #3482

Open
HappyEarthDay opened this issue Jan 27, 2025 · 4 comments
Open
Labels
bug Something isn't working unconfirmed-by-user

Comments

@HappyEarthDay
Copy link

Description

Currently the standards called:
Sets the Cross-tenant access setting to trust external MFA
is Enabled for AllTenants but is disabled when I check in Entra. I confirmed in the logbook that the standard is disabling it instead of enabling it.

AllTenants Standard
Image
Entra Portal:
Image
Logbook:
Image

Environment data

See screenshots above
@HappyEarthDay HappyEarthDay added bug Something isn't working unconfirmed-by-user labels Jan 27, 2025
Copy link

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@KelvinTegelaar
Copy link
Owner

This looks like a conversion issue, can you delete this from your standard, save that standard, refresh the page, and readd the standard as a test.

@HappyEarthDay
Copy link
Author

HappyEarthDay commented Jan 27, 2025

This looks like a conversion issue, can you delete this from your standard, save that standard, refresh the page, and readd the standard as a test.

I'm not using converted standards - I made all mine fresh.

Edit: I just did it anyway just to be sure and ran the standards again. The same thing happened.

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

@kris6673
Copy link
Contributor

I had a look at it with @HappyEarthDay and it seems the standards template might have been made pre 7.0.4.
For a different standard, but this is how it looked:

"UserSubmissions": {
        "action": [
          {
            "value": "Remediate",
            "label": "Remediate"
          },
          {
            "value": "Report",
            "label": "Report"
          }
        ],
        "standards": {
          "UserSubmissions": {
            "state": {
              "value": "enable",
              "label": "Enabled"
            },
            "email": ""
          }
        }
      },

Newly made and correctly formatted:

"UserSubmissions": {
        "action": [
          {
            "value": "Remediate",
            "label": "Remediate"
          }
        ],
        "standards": {
          "UserSubmissions": {
            "state": "enable",
            "email": ""
          }
        }
      }

Saving the standard again did not update it to the right formatting.
This is not an issue for ppl that converted their standards, only for ppl that remade them from scratch in v7.0.1-7.0.3

Remaking the standard templates fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed-by-user
Projects
None yet
Development

No branches or pull requests

3 participants