Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't view drinker page for drinker with period in username #313

Closed
jlopp opened this issue Aug 18, 2014 · 5 comments
Closed

can't view drinker page for drinker with period in username #313

jlopp opened this issue Aug 18, 2014 · 5 comments

Comments

@jlopp
Copy link

jlopp commented Aug 18, 2014

We have a user whose name is in the form "john.doe" and when you try to go to the drink page at http://kegbot.brontolabs.com/drinkers/john.doe it redirects to http://kegbot.brontolabs.com/kegadmin/devices/link/ rather than displaying the user's drinking stats.

I'm assuming this is an issue with the period in the username, because if you try to view a user that simply doesn't exist, such as http://kegbot.brontolabs.com/drinkers/notauser then a 404 error is returned. On a related note, it would probably be helpful to handle that case as well and just display a nice 'user does not exist' error.

@mik3y
Copy link
Member

mik3y commented Aug 18, 2014

Thanks for the report. Periods in username are kosher, looks like it's a problem with the link/ url matcher (should be ^link/). 1 satoshi says your john doe's name ends in link..

@jlopp
Copy link
Author

jlopp commented Aug 18, 2014

Why yes, you nailed it!

@mik3y mik3y closed this as completed in be393fe Aug 18, 2014
@mik3y
Copy link
Member

mik3y commented Aug 18, 2014

Awesome. 1BPis1VNaRViBZEWU4Udq4KY69zj3p9phv

😉

@mik3y
Copy link
Member

mik3y commented Aug 18, 2014

LOL - thanks! Guess I'm on the hook for finally writing that in-app BTC tipjar now..

@jlopp
Copy link
Author

jlopp commented Aug 18, 2014

For sure; I'll put a $50 bounty on completion of an in-app BTC tipjar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants