Address linter warnings in ush/gldas_archive.sh and ush/gldas_post.sh

Refs NOAA-EMC#1014
KateFriedman-NOAA · Sep 13, 2022 · 2e810c3 · 2e810c3
1 parent 9f94a97
commit 2e810c3
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 39 deletions.
diff --git a/ush/gldas_archive.sh b/ush/gldas_archive.sh
@@ -17,67 +17,69 @@
 
 source "${HOMEgfs:?}/ush/preamble.sh"
 
-if [ $# -lt 1 ]; then
+if [[ $# -lt 1 ]]; then
   echo "usage: $0 sdate [edate]"
   exit $?
 fi
 
+FINDDATE=${FINDDATE:?}
+
 sdate=$1
-edate=$(sh ${FINDDATE} $1 d+1)
-if [ $# -gt 1 ]; then edate=$2 ; fi
+edate=$(sh "${FINDDATE}" "$1" d+1)
+if [[ $# -gt 1 ]]; then edate=$2 ; fi
 
-yyyy=$(echo ${sdate} | cut -c1-4)
+yyyy=$(echo "${sdate}" | cut -c1-4)
 
 ### save all output to day1 directory
-export COMDIR=${COM_OUT}
+export COMDIR=${COM_OUT:?}
 
-mkdir -p ${COMDIR}/gldas.${sdate}
-yyyymmdd=$(sh ${FINDDATE} ${sdate} d+1)
-while [ ${yyyymmdd} -le ${edate} ]; do
+mkdir -p "${COMDIR}/gldas.${sdate}"
+yyyymmdd=$(sh "${FINDDATE}" "${sdate}" d+1)
+while [[ "${yyyymmdd}" -le "${edate}" ]]; do
 
-mkdir -p ${COMDIR}/gldas.${yyyymmdd}
+mkdir -p "${COMDIR}/gldas.${yyyymmdd}"
 
-yyyy=$(echo ${yyyymmdd} | cut -c1-4)
-cp ${RUNDIR}/EXP901/NOAH/${yyyy}/${yyyymmdd}/* ${COMDIR}/gldas.${sdate}
+yyyy=$(echo "${yyyymmdd}" | cut -c1-4)
+cp "${RUNDIR:?}/EXP901/NOAH/${yyyy}/${yyyymmdd}"/* "${COMDIR}/gldas.${sdate}"
 
-yyyymmdd=$(sh ${FINDDATE} ${yyyymmdd} d+1)
+yyyymmdd=$(sh "${FINDDATE}" "${yyyymmdd}" d+1)
 done
 
-cp ${RUNDIR}/sfc.gaussian.nemsio.${sdate} ${COMDIR}/gldas.${sdate}
+cp "${RUNDIR}/sfc.gaussian.nemsio.${sdate}" "${COMDIR}/gldas.${sdate}"
 
 ### rename grb files
 
 yyyymmdd=${sdate}
-while [ ${yyyymmdd} -lt ${edate} ]; do
+while [[ "${yyyymmdd}" -lt "${edate}" ]]; do
 
 day1=${yyyymmdd}
-day2=$(sh ${FINDDATE} ${yyyymmdd} d+1)
-mv ${COMDIR}/gldas.${sdate}/LIS.E901.${day2}00.NOAH.grb ${COMDIR}/gldas.${sdate}/LIS.E901.${day1}00.NOAH.grb
+day2=$(sh "${FINDDATE}" "${yyyymmdd}" d+1)
+mv "${COMDIR}/gldas.${sdate}/LIS.E901.${day2}00.NOAH.grb" "${COMDIR}/gldas.${sdate}/LIS.E901.${day1}00.NOAH.grb"
 
-yyyymmdd=$(sh ${FINDDATE} ${yyyymmdd} d+1)
+yyyymmdd=$(sh "${FINDDATE}" "${yyyymmdd}" d+1)
 done
 
 ### save noah.rst.day2 to day2 directory for next day gldas restart
 
-yyyymmdd=$(sh ${FINDDATE} ${sdate} d+1)
-yyyy=$(echo ${yyyymmdd} | cut -c1-4)
-mkdir -p ${COMDIR}/gldas.${edate}
-cp ${RUNDIR}/EXP901/NOAH/${yyyy}/${edate}/LIS.E901.${edate}00.Noahrst ${COMDIR}/gldas.${yyyymmdd}/noah.rst.${edate}
+yyyymmdd=$(sh "${FINDDATE}" "${sdate}" d+1)
+yyyy=$(echo "${yyyymmdd}" | cut -c1-4)
+mkdir -p "${COMDIR}/gldas.${edate}"
+cp "${RUNDIR}/EXP901/NOAH/${yyyy}/${edate}/LIS.E901.${edate}00.Noahrst" "${COMDIR}/gldas.${yyyymmdd}/noah.rst.${edate}"
 
 ### generate and save gdas.t${cyc1}z.sfcanl.nemsio.gldas.day4 to day4 directory for next cycle gfs restart
 
-mkdir -p ${COMDIR}/gldas.${edate}
+mkdir -p "${COMDIR}/gldas.${edate}"
 gdate=${edate}
 gdas_date=${gdate}.${cyc}0000
-cp sfc_data.tile1.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile1.nc
-cp sfc_data.tile2.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile2.nc
-cp sfc_data.tile3.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile3.nc
-cp sfc_data.tile4.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile4.nc
-cp sfc_data.tile5.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile5.nc
-cp sfc_data.tile6.nc ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile6.nc
+cp sfc_data.tile1.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile1.nc"
+cp sfc_data.tile2.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile2.nc"
+cp sfc_data.tile3.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile3.nc"
+cp sfc_data.tile4.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile4.nc"
+cp sfc_data.tile5.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile5.nc"
+cp sfc_data.tile6.nc "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile6.nc"
 
-cp sfc.gaussian.nemsio.gldas ${COMDIR}/gldas.${edate}/${gdas_date}.sfc.gaussian.nemsio.gldas
+cp sfc.gaussian.nemsio.gldas "${COMDIR}/gldas.${edate}/${gdas_date}.sfc.gaussian.nemsio.gldas"
 
-cp sfc.gaussian.nemsio ${COMDIR}/gldas.${edate}/${gdas_date}.sfc.gaussian.nemsio.gdas
+cp sfc.gaussian.nemsio "${COMDIR}/gldas.${edate}/${gdas_date}.sfc.gaussian.nemsio.gdas"
 
-echo ${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile6.nc
+echo "${COMDIR}/gldas.${edate}/${gdas_date}.sfcanl_data.tile6.nc"
diff --git a/ush/gldas_post.sh b/ush/gldas_post.sh
@@ -2,31 +2,33 @@
 
 source "${HOMEgfs:?}/ush/preamble.sh"
 
-if [ $# -lt 2 ]; then
+if [[ $# -lt 2 ]]; then
   echo "usage: $0 gldas.gbin gdas.sfcanl"
   err_exit 99
 fi
 
-cd ${RUNDIR}
+cd "${RUNDIR:?}" || exit
 
 export pgm=gldas_post
-  . prep_step
+# shellcheck disable=SC1091
+. prep_step
+# shellcheck disable=
 
 gbin=$1
 sfcanl=$2
 
 rm -f fort.11 fort.12 fort.22
-cp ${gbin} fort.11
-cp ${sfcanl} fort.12
+cp "${gbin}" fort.11
+cp "${sfcanl}" fort.12
 
-${EXECgldas}/gldas_post >>${pgmout} 2>errfile
+"${EXECgldas:?}/gldas_post" >>"${pgmout:?}" 2>errfile
 export err=$?; err_chk
 
 cp fort.22 ./gldas.nemsio
-cp  fort.22 ${sfcanl}.gldas
+cp  fort.22 "${sfcanl}.gldas"
 rm -f fort.11 fort.12 fort.22
 
-echo ${sfcanl}.gldas
+echo "${sfcanl}.gldas"
 
 exit $?