Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guide? #5

Closed
delirious-lettuce opened this issue Feb 3, 2018 · 3 comments
Closed

Style guide? #5

delirious-lettuce opened this issue Feb 3, 2018 · 3 comments

Comments

@delirious-lettuce
Copy link

delirious-lettuce commented Feb 3, 2018

This looks like a neat project but I am curious about the style of the code itself and since the project only seems to be four days old, this might be a good time to make changes.

For example:

def competitionsListCli(self, page = 1, search = '', csv = False):

Many projects seem to stay pretty close to PEP8 except maybe loosening the line length recommendation from 79 chars to around 100 chars.

These are small things but fixing them would touch many lines of code in the project and I wasn't sure if that would be frowned upon. Any thoughts?

@pulkitmaloo
Copy link

Can I work on making the code PEP8 Style?

@ghost
Copy link

ghost commented Apr 12, 2018

Apologies for the late response. I'm picking up this project now.

Conforming the handwritten code to Google's python style is on my short-term todo list. At least one version will not contain breaking changes, but I don't want to leave in the old method names too long.

@ghost ghost self-assigned this Apr 12, 2018
@ghost
Copy link

ghost commented Apr 16, 2018

Fixed in 4e29c89. Wound up just including the breaking changes. Please see the changelog - they shouldn't affect command line only use.

The code was formatted per Google style, which has a lot of similarities to pep8, but is not identical.

@ghost ghost closed this as completed Apr 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants