Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior when installation finds old files left from previous installation of mod #2055

Closed
Ricochetv1 opened this issue May 25, 2017 · 6 comments
Labels
Enhancement New features or functionality

Comments

@Ricochetv1
Copy link

I request a change in behavior of CKAN when it comes across old ship files from previous installations of various mods.
Instead of just killing the installation, let the user choose whether or not to continue, as the user generally has more knowledge of what is going on with their KSP installation and can make the logical decision whether or not to overwrite those files.

CKAN Version: 1.22.1-0-g174271a

Operating System: Win7

The issue you are experiencing: Stops installation when it finds ships left behind from previous installation

How to recreate this issue: Install a mod, delete the .json registry, manually remove the mods in GameData, then reinstall the mods. If ships were left behind, it kills the installation.

CKAN error codes (if applicable):

@ayan4m1 ayan4m1 added the Enhancement New features or functionality label Sep 17, 2017
@dittoslash
Copy link

dittoslash commented Nov 24, 2017

Fixed, maybe. Probably not stable, and you'll have to compile it yourself, but it's there if you want it. It Hasn't Broken™ for me, so it's probably worth a try. Doesn't actually give you a choice, just overwrites it. https://github.com/dittoslash/CKAN

@HebaruSan
Copy link
Member

@dittoslash, if you make a new pull request, it's much easier for the project team to check your changes, discuss, and merge them. Plus it has its own entry in the outstanding request lists, whereas replies to issues are easy to lose track of.

@dittoslash
Copy link

it's not stable, and just overwrites everything. if you're fine with that, i'll put it up :p

@HebaruSan
Copy link
Member

Oh, nevermind; yes, that would break the normal case where the user tries to install two conflicting mods, as opposed to trying to manually reset everything and missing some things.

@HebaruSan
Copy link
Member

It's a good idea to uninstall all mods in CKAN before you start mucking around with the files manually; this will take care of deleting the ships for you. The wiki's clean and reinstall process has been updated to recommend that, as well as include steps to clean up the ships if you still need to do that for some reason:

@HebaruSan
Copy link
Member

As of #3043 the user is prompted to overwrite unowned files. I think that addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants