KSP Installation list loses currently invalid installs when adding a new installation

[politas]

Steps to reproduce
Add a KSP installation "install1"
Move KSP installation "install1" to a different location
Add KSP installation "install2"
Return KSP installation "install1" to its former location

install1 will not be selectable on starting CKAN

[politas]

See also related #1836

[ayan4m1]

This is intentional as far as the source is concerned: https://github.com/KSP-CKAN/CKAN/blob/master/Core/KSPManager.cs#L290

The KSP ctor throws an exception if the install isn't valid:

if (!IsKspDir(gameDir))
{
throw new NotKSPDirKraken(gameDir);
}

Any ideas on how you want that all to work?

[politas]

Ideally, unavailable instances would show up in the KSP Install list greyed out, so they can be removed (fixing #1836), and they won't then be forgotten when another instance is added (fixing this)

[ayan4m1]

Ah, makes sense - that is kinda more of an enhancement rather than a ckan.dll bug right?

[politas]

I suppose you could call it an enhancement that solves two related bugs.

[ayan4m1]

Gotcha, been working on the more comprehensive solution over the past few days.

[politas]

@ayan4m1 , while you're working on this bit of code, we've had a feature request on the forums to maintain the "default" KSP version when selecting a non-default install. We would then need to add a button to clear the current default. Does that seem simple enough to implement?