Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column for date mod updated #1155

Closed
anxcon opened this issue Jun 22, 2015 · 8 comments · Fixed by #3096
Closed

column for date mod updated #1155

anxcon opened this issue Jun 22, 2015 · 8 comments · Fixed by #3096
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI Spec Issues affecting the spec ★★☆

Comments

@anxcon
Copy link

anxcon commented Jun 22, 2015

alot of times ckan gets a new mod and i don't notice it, be it complete new mod, or recently updated to the current ksp version

if there was a column for date last updated (as in version of mod added or changed, not ckan scan updating full db) i could sort by date :) see whats new

@janbrohl
Copy link
Contributor

Currently there are no dates in the underlying ckan-metadata at all (also no helpful ones in the master.zip) so this propably depends on #1116 or on some git-magic (meta-metadata?)

@anxcon
Copy link
Author

anxcon commented Jun 25, 2015

even if the date database is started at current date would be fine, still helps to to sort newest since then :)

@pjf
Copy link
Member

pjf commented Jul 16, 2015

Lots of people like this, so I'm sticking a bunch of higher priority labels on it.

@pjf pjf added ★★☆ Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN labels Jul 16, 2015
@politas
Copy link
Member

politas commented Feb 10, 2016

When adding this, time zones will need to be considered. It is probably easiest to use UTC Date/time in the metadata, and then look at converting to local time zone in the client.

@funkcanna
Copy link

This would be very useful. Im currently checking the 1.1 updates but as more get added its harder to keep track of the new ones.

@PyroSA
Copy link

PyroSA commented Apr 19, 2016

This would be awesome addition, I've limited myself to checking the new list after every refresh, as that was the only feasible way of seeing what's fresh. Suspected the lack of backing data would be exist, but even a local date would suffice for my needs.

@techman83
Copy link
Member

I've given this a lot of thought as we have a much more flexible architecture since #2789

These are my dot point thoughts:

  • Firstly this needs to be discussed and added to the Spec, ie
    • Field assumed to be UTC
    • Full date / time
    • ISO 8601 compliant (2019-11-07T01:29:59+00:00)
  • netkan.exe should remain the source of the truth. It should be responsible for populating the release_date field (name pending)
    • This would enable us to initially use the system timestamp, but also enhance our transformers to retrieve this information from the relevant APIs where available
  • An optional --release-date flag on netkan.exe means we can switch this on when we're ready
  • Metadata pull request testing on CKAN-meta to fail if release_date is changed or removed.
  • The indexer can be switched from using an MD5 to an equivalence check via the Ckan class. For example, if an existing ckan is found, load it in as a Ckan and compare it to the received inflation. The Ckan class to have a custom __eq__ method that compares the objects, but ignores the release_date
    • This keeps netkan.exe as the source of the truth
    • Allows us to write to disk exactly as it's received from netkan.exe
    • Keeps our existing logic, we just compare inflated == existing instead of the MD5s
    • We can do this in advance to enabling the release_date flag
    • This is trivial to write a test case for and doesn't require any complicated logic changes to the indexer
  • We should treat historical data as a separate exercise. We can dig out reasonable approximations from the git history and populate them in all in one pass (disabling webhooks/canceling the tests as needed).

We have some good and flexible tools available now to make this happen, but we don't want to make it any more complicated than it needs to be. Reducing complexity was a huge motivator for re-architecting in the first place and while the big picture is a bit more complicated and contains a lot of moving parts; the individual components are much much simpler.

@techman83
Copy link
Member

I've added a formal proposal for the release date field (#2916). Comments/Suggestions welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI Spec Issues affecting the spec ★★☆
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants