Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue while upgrading from .25.1 to .25.2 #102

Closed
thomaslima opened this issue Mar 20, 2018 · 4 comments
Closed

Potential issue while upgrading from .25.1 to .25.2 #102

thomaslima opened this issue Mar 20, 2018 · 4 comments

Comments

@thomaslima
Copy link
Collaborator

A labmate reported that when he installed the new klayout, he got that “Got an empty string where a real number was expected” exception.

This could be solved by deleting the ~/.klayout/klayoutrc file.

Can anyone help upgrade from a clean .25.1 to a .25.2 to check whether this will be a major issue for end users? Otherwise, more in the long term, we have to change klayout code so that it's failsafe with regards to "corrupted" klayoutrc.

@klayoutmatthias
Copy link
Collaborator

Hi Thomas,

I will try to reproduce the issue.

Matthias

@thomaslima
Copy link
Collaborator Author

Don't try too hard. Might be a false alarm, as he at some point installed a dev version.

@klayoutmatthias
Copy link
Collaborator

No, not a false alarm. A real issue. Thanks a lot for testing!!!

I did not see that myself (yet) because I did not try to upgrade (yet).

I have fixed that plus made the application safe against failure when reading the config. Config errors are reported but ignored otherwise.

Thanks again and best regards,

Matthias

@thomaslima
Copy link
Collaborator Author

Thank you for figuring this out. We really appreciate it.

LG
Thomas

Kazzz-S pushed a commit to Kazzz-S/klayout that referenced this issue Mar 21, 2018
The reason was that for 0.25.1 "macro-editor-font-size" was allowed
to be an empty string (the default). Which meant: take default application
font size. In 0.25.2 this now was required to be a number and 0 was
the default for "auto" font size.

Two changes:
 - The default is back to empty string ("0" is still allowed as default)
 - The application was made safe against broken configuration files: an
   error is printed to the log, but apart from that the application
   will work (the configuration value is ignored however).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants