Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TypeScript type definitions from @jupiterone/data-model #129

Open
philidem opened this issue May 4, 2020 · 2 comments
Open

Use TypeScript type definitions from @jupiterone/data-model #129

philidem opened this issue May 4, 2020 · 2 comments

Comments

@philidem
Copy link
Contributor

philidem commented May 4, 2020

To make it easier to catch schema validation errors during development, we should generate typescript type definitions from our JSON schema for the data model.

@ctdio
Copy link
Contributor

ctdio commented May 5, 2020

We should probs create an issue over in https://github.com/jupiterone/data-model since that would probably be the place to do the type gen.

@aiwilliams aiwilliams changed the title Generate typescript type definitions from JSON schema Use TypeScript type definitions from @jupiterone/data-model May 5, 2020
@aiwilliams
Copy link
Contributor

I've created JupiterOne/data-model#12 and changed this issue to indicate that we should use the types from data-model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants