Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report and finalize test coverage #147

Closed
hustf opened this issue Mar 23, 2019 · 1 comment
Closed

Report and finalize test coverage #147

hustf opened this issue Mar 23, 2019 · 1 comment

Comments

@hustf
Copy link
Collaborator

hustf commented Mar 23, 2019

Coverage.jl in the latest version again gives realistic estimates. After release of Julia 1.0, the percentage reported was ~70% while actual coverage was ~96%. Also, PR#143 / PR#145 has left a few uncovered spots.

Add to

    error_test.jl: HTTP.jl :240, 243, 405
                                Websockets.jl: 184, 295
                               show_ws.jl: 147, 148
    Drop HTTP.jl: 395
    client_serverWS_test.jl: serve(::IPv4)
    show_test.jl: 176, 177
@hustf hustf mentioned this issue Mar 23, 2019
Merged
@hustf
Copy link
Collaborator Author

hustf commented Mar 24, 2019

Work in progress here:
https://github.com/JuliaWeb/WebSockets.jl/tree/issue147

@hustf hustf mentioned this issue Mar 24, 2019
Merged
@hustf hustf closed this as completed Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hustf