You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMHO, it might be desirable to have getaffine and setaffine generate and write matrices suitable for Julia's 1-based indexing. The relevant fields of NIfTI headers are such that they work for 0-based indexing. This would make using these matrices much easier within Julia.
I can understand if you are not interested in making such a change as it might break existing code. Some have also criticised the SPM nifti objects for including this conversion between 0 and 1 indexing.
The text was updated successfully, but these errors were encountered:
I have an almost completely functional branch working where I've switched everything to 1 based indexing (including the phase/frequency dimensions). It's almost completely ready to be pushed to master with the exception of some issues with qform.
IMHO, it might be desirable to have getaffine and setaffine generate and write matrices suitable for Julia's 1-based indexing. The relevant fields of NIfTI headers are such that they work for 0-based indexing. This would make using these matrices much easier within Julia.
I can understand if you are not interested in making such a change as it might break existing code. Some have also criticised the SPM nifti objects for including this conversion between 0 and 1 indexing.
The text was updated successfully, but these errors were encountered: