Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request/change #24

Open
JohnAshburner opened this issue Jun 27, 2019 · 1 comment
Open

feature request/change #24

JohnAshburner opened this issue Jun 27, 2019 · 1 comment

Comments

@JohnAshburner
Copy link

IMHO, it might be desirable to have getaffine and setaffine generate and write matrices suitable for Julia's 1-based indexing. The relevant fields of NIfTI headers are such that they work for 0-based indexing. This would make using these matrices much easier within Julia.

I can understand if you are not interested in making such a change as it might break existing code. Some have also criticised the SPM nifti objects for including this conversion between 0 and 1 indexing.

@Tokazama
Copy link
Member

Tokazama commented Jun 27, 2019

I have an almost completely functional branch working where I've switched everything to 1 based indexing (including the phase/frequency dimensions). It's almost completely ready to be pushed to master with the exception of some issues with qform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants