Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility PR broke building with Tracy enabled #49728

Closed
KristofferC opened this issue May 10, 2023 · 1 comment
Closed

Visibility PR broke building with Tracy enabled #49728

KristofferC opened this issue May 10, 2023 · 1 comment

Comments

@KristofferC
Copy link
Member

Errors with:

/Users/kristoffercarlsson/julia/src/timing.c:28:1: error: visibility does not match previous declaration
JL_DLLEXPORT uint64_t jl_timing_enable_mask = ~((1ull << JL_TIMING_ROOT) |
^
/Users/kristoffercarlsson/julia/src/support/dtypes.h:89:23: note: expanded from macro 'JL_DLLEXPORT'
# define JL_DLLEXPORT JL_DLLIMPORT
                      ^
/Users/kristoffercarlsson/julia/src/support/dtypes.h:85:38: note: expanded from macro 'JL_DLLIMPORT'
#define JL_DLLIMPORT __attribute__ ((visibility("default")))
                                     ^
./julia_internal.h:29:13: note: previous attribute is here
#pragma GCC visibility push(hidden)
            ^
/Users/kristoffercarlsson/julia/src/timing.c:38:1: error: visibility does not match previous declaration
JL_DLLEXPORT uint64_t jl_timing_counts[(int)JL_TIMING_LAST] = {0};
^
/Users/kristoffercarlsson/julia/src/support/dtypes.h:89:23: note: expanded from macro 'JL_DLLEXPORT'
# define JL_DLLEXPORT JL_DLLIMPORT
                      ^
/Users/kristoffercarlsson/julia/src/support/dtypes.h:85:38: note: expanded from macro 'JL_DLLIMPORT'
#define JL_DLLIMPORT __attribute__ ((visibility("default"))

Ref #49600

cc @vtjnash

@vtjnash
Copy link
Member

vtjnash commented May 10, 2023

Looks like it was being declared in the wrong place (JL_DLLEXPORT should go in headers, and is optional to duplicate in the source code file). We are a bit more strict about getting that right after #49600, as usually the linker would previously usually accept errors by generating extra stub code to work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants