Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using should trigger Pkg's parallel precompilation #48259

Closed
ericphanson opened this issue Jan 12, 2023 · 2 comments · Fixed by #49242
Closed

using should trigger Pkg's parallel precompilation #48259

ericphanson opened this issue Jan 12, 2023 · 2 comments · Fixed by #49242
Labels
compiler:codegen Generation of LLVM IR and native code parallelism Parallel or distributed computation

Comments

@ericphanson
Copy link
Contributor

I think Base should add a hook so that when Pkg is loaded, using PkgX triggers parallel precompilation instead of serial. It's not intuitive for that there's different precompilation modes with hugely different runtimes, and I think it's a common footgun to accidentally use the non-parallel version.

@Roger-luo
Copy link
Contributor

Or can we have this by default, and have a flag to turn it off?

@ViralBShah ViralBShah added compiler:codegen Generation of LLVM IR and native code parallelism Parallel or distributed computation labels Jan 16, 2023
@IanButterworth
Copy link
Member

IanButterworth commented Jan 17, 2023

I think to do this without regression Pkg.precompile needs to start showing the precompile warnings that are currently only shown in code load precompilation. Proposal here: JuliaLang/Pkg.jl#3319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants