Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jl_get_cfunction_trampoline is not thread-safe #38709

Closed
vchuravy opened this issue Dec 4, 2020 · 0 comments · Fixed by #39621
Closed

jl_get_cfunction_trampoline is not thread-safe #38709

vchuravy opened this issue Dec 4, 2020 · 0 comments · Fixed by #39621

Comments

@vchuravy
Copy link
Member

vchuravy commented Dec 4, 2020

As seen in the wild (JuliaGPU/CUDA.jl#588) and noted as a todo
(

julia/src/runtime_ccall.cpp

Line 271 in 8629e21

// TODO: need a thread lock around the cache access parts of this function
) jl_get_cfunction_trampoline is not thread-safe.

@vtjnash adding a lock to each htable_t seems heavy. Should each callsite codegen a lock?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lock cfunction trampoline cache and freelist accesses. JuliaLang/julia
1 participant
@vchuravy