From 8089637e5fbb914292fe3c6034538bb93592dfd3 Mon Sep 17 00:00:00 2001 From: Jarrett Revels Date: Fri, 6 Jul 2018 17:08:43 +0200 Subject: [PATCH] a test that was checking for exact/optimal inference result is now broken Justification for allowing this test to remain broken for now: - benchmarking the expression (including downstream toy calculations on the output, e.g. broadcast sin) using BenchmarkTools reveals no actual performance difference - inference returning an optimal result before was probably reliant on the broken subtyping behavior; correctness >>> performance - inference is still returning a fairly tightly bounded, correct Union type --- test/sets.jl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/sets.jl b/test/sets.jl index 631e2d69c295ed..3db0d195e4e1a3 100644 --- a/test/sets.jl +++ b/test/sets.jl @@ -557,7 +557,8 @@ end x = @inferred replace(x -> x > 1, [1, 2], missing) @test isequal(x, [1, missing]) && x isa Vector{Union{Int, Missing}} - x = @inferred replace([1, missing], missing=>2) + @test_broken @inferred replace([1, missing], missing=>2) + x = replace([1, missing], missing=>2) @test x == [1, 2] && x isa Vector{Int} x = @inferred replace([1, missing], missing=>2, count=1) @test x == [1, 2] && x isa Vector{Union{Int, Missing}}