Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Bump AxisAlgorithms and place upper bound on julia version for prior releases #5737

Merged
merged 2 commits into from
Jul 29, 2016
Merged

Bump AxisAlgorithms and place upper bound on julia version for prior releases #5737

merged 2 commits into from
Jul 29, 2016

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 28, 2016

Includes 0.5 fix by @carlobaldassi, and implements a recommendation to put an upper bound on the previous releases.

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2016

you probably don't want the trailing dash in an upper bound. that excludes the very first commit of 0.5-dev.

@timholy
Copy link
Member Author

timholy commented Jul 28, 2016

What would you suggest instead? I don't really feel the need to start doing a git-bisect to figure out where the first breakage occurred. What's wrong with being conservative?

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2016

I would leave off the dash, or do rc0 if you want it to take effect immediately.

@timholy
Copy link
Member Author

timholy commented Jul 28, 2016

OK now?

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2016

removing the dash on the lower bound for existing tags would make the package no longer installable on prereleases of 0.4 where it might have been working? probably doesn't affect anyone, but I'm usually more targeted about touching lower bounds

@timholy
Copy link
Member Author

timholy commented Jul 28, 2016

(You're annoyingly good at this...what would we ever do without you? 😜) How about this?

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2016

When things quiet down post-release I'll try to write a kelman-bot to automate most of the things I check for in review here. This version looks great now.

@timholy
Copy link
Member Author

timholy commented Jul 29, 2016

Seems like it should be possible to harness PkgEval for doing julia version recommendations.

@tkelman
Copy link
Contributor

tkelman commented Jul 29, 2016

I (or someone else) will need to implement the easy parts of JuliaCI/PackageEvaluator.jl#131 first to make that feasible, but yes.

@tkelman tkelman merged commit 95db08e into JuliaLang:metadata-v2 Jul 29, 2016
@timholy timholy deleted the teh/axisalgorithms branch July 29, 2016 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants