-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBLAS 0.3.13 ex-shift patch not working #833
Closed
Labels
upstream
The issue is with an upstream dependency, e.g. LLVM
Comments
I don't see this patch in Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/tree/master/O/OpenBLAS/OpenBLAS%400.3.13/bundled/patches So it just seems like it needs to be added there. |
ViralBShah
referenced
this issue
in JuliaPackaging/Yggdrasil
Apr 4, 2021
ViralBShah
referenced
this issue
in JuliaPackaging/Yggdrasil
Apr 4, 2021
ViralBShah
referenced
this issue
in JuliaLang/julia
Apr 4, 2021
JuliaLang/julia#40343 should pick up the new binaries in master. |
ViralBShah
referenced
this issue
in JuliaLang/julia
Apr 4, 2021
33 tasks
ElOceanografo
referenced
this issue
in ElOceanografo/julia
May 4, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <lekand@gmail.com>
antoine-levitt
referenced
this issue
in antoine-levitt/julia
May 9, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <lekand@gmail.com>
johanmon
referenced
this issue
in johanmon/julia
Jul 5, 2021
* Use 0.3.13+4 openblas binaries to fix #40279 * Add tests and doctest fixes for JuliaLang#40343 (JuliaLang#40346) * Update checksums * changed a doctest to have nicer output Co-authored-by: Pablo San-Jose <lekand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There must have been some kind of problem with the upgrade to OpenBLAS 0.3.13 in JuliaLang/julia#39216. That PR included a patch called
openblas-exshift.patch
intended to bring in the fix in OpenMathLib/OpenBLAS#3091 without having to wait for OpenBLAS 0.3.14, but it seems the patch does not work. I don't know why, but the following test, discussed in the original issue Reference-LAPACK/lapack#475, still fails in Julia 1.6 and nightlyThen, on Intel + macOS
The failure is platform dependent (other pencils that fail for other platforms are available in Reference-LAPACK/lapack#475), and seems similar to #832.
Also, using MKL (Julia 1.5.3 + MKL.jl) never fails.
I'm clueless about the whole Yggdrasil BinaryBuilder machinery, so I cannot fathom why the patch doesn't work (it did work when I compiled locally with it back in the day). However, perhaps the best thing is to wait for OpenBLAS 0.3.14 to be released with the fix and bake that in instead.
The text was updated successfully, but these errors were encountered: