Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't terminate notebook() function in Julia REPL in 1.8 on Windows #1048

Open
nilshg opened this issue Aug 3, 2022 · 4 comments
Open

Can't terminate notebook() function in Julia REPL in 1.8 on Windows #1048

nilshg opened this issue Aug 3, 2022 · 4 comments

Comments

@nilshg
Copy link

nilshg commented Aug 3, 2022

In 1.7.3 I can do:

julia> using IJulia

julia> notebook()
[ Info: running setenv(...)

# Single Ctrl+C

Process(setenv(..., ProcessSignaled(2))

julia> 

In 1.8-rc3 this doesn't work (tested on both cmd.exe and powershell):

julia> using IJulia

julia> notebook()
[ Info: running setenv(...)

# Single Ctrl+C

# Nothing happens

# Multiple Ctrl+Cs

WARNING: Force throwing a SIGINT

and the whole Julia session is dead.

@nilshg nilshg changed the title Can't terminate notebook() function in Julia REPL in 1.8-rc3 on Windows Can't terminate notebook() function in Julia REPL in 1.8 on Windows Aug 30, 2022
@nilshg
Copy link
Author

nilshg commented Aug 30, 2022

Edited to add that this isn't fixed by using 1.8 stable release. There's a related Pluto issue here: fonsp/Pluto.jl#2136

@benz0li
Copy link

benz0li commented Aug 30, 2022

Some slightly different results for Debian 11 (bullseye):

Julia 1.8.0, JupyterLab Terminal

julia> using IJulia

julia> notebook()
[ Info: running `/usr/local/bin/jupyter notebook`
^C^C^C^C^C^CWARNING: Force throwing a SIGINT
Process(setenv(`/usr/local/bin/jupyter notebook`; dir="/home/benz0li"), ProcessExited(0))

julia>

Julia 1.8.0, code-server (aka VS Code) Terminal, Julia REPL

julia> using IJulia

julia> notebook()
[ Info: running `/usr/local/bin/jupyter notebook`
^C
Process(setenv(`/usr/local/bin/jupyter notebook`; dir="/home/benz0li"), ProcessExited(0))

julia>

ℹ️ May be reproduced at https://demo.jupyter.b-data.ch or with docker run --rm -it -p 8888:8888 registry.gitlab.b-data.ch/jupyterlab/julia/pubtools

@fonsp
Copy link
Member

fonsp commented Sep 5, 2022

I opened a Julia issue about a change in interrupt behaviour on Julia 1.8, which I suspect to be the cause here.

JuliaLang/julia#46635

So far I only have my result on MacOS, perhaps someone using a different OS could try to reproduce the issue, and leave a comment with their versioninfo()?

@fonsp
Copy link
Member

fonsp commented Sep 21, 2022

In Pluto, we were able to work around this issue, see fonsp/Pluto.jl#2293 , maybe the same technique would also work for IJulia! See JuliaLang/julia#46635 for a discussion about this workaround and alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants