Fatal error printed as warning

[SimonDanisch]

This error:

BugReporting.jl/src/BugReporting.jl

Line 43 in 6c80d90

print(io, """

Seems to be fatal. But it's printed without any highlighting and BugReporting doesn't complain and happily uploads a trace, without actually doing anything.

[Keno]

Sounds like there's two things to fix
1: The printing
2: Why did it do the upload anyway if threw an error?

[theogf]

I got the same issue and just changing /etc/sysctl.conf did not solve the problem directly (maybe it needed a reboot). However changing directly the content of /proc/sys/kernel/perf_event_paranoid to 1 solved it directly

[maleadt]

The error is fatal nowadays:

$ echo 3 | sudo tee /proc/sys/kernel/perf_event_paranoid
3
$ julia
julia> using BugReporting
julia> make_interactive_report("rr")
ERROR: InvalidPerfEventParanoidError
rr needs /proc/sys/kernel/perf_event_paranoid <= 1, but it is 3.
Change it to 1, or use `JULIA_RR_RECORD_ARGS=-n julia --bug-report=rr` (slow).
Consider putting 'kernel.perf_event_paranoid = 1' in /etc/sysctl.conf
or change it temporarily by
    echo 1 | sudo tee /proc/sys/kernel/perf_event_paranoid

Stacktrace:
 [1] check_perf_event_paranoid(path::String; record_flags::Vector{SubString{String}})
   @ BugReporting ~/Julia/pkg/BugReporting/src/BugReporting.jl:61
 [2] check_perf_event_paranoid(path::String) (repeats 2 times)
   @ BugReporting ~/Julia/pkg/BugReporting/src/BugReporting.jl:55
 [3] #rr_record#6
   @ ~/Julia/pkg/BugReporting/src/BugReporting.jl:122 [inlined]
 [4] (::BugReporting.var"#20#21"{Vector{Any}})(trace_dir::String)
   @ BugReporting ~/Julia/pkg/BugReporting/src/BugReporting.jl:234
 [5] create_artifact(f::BugReporting.var"#20#21"{Vector{Any}})
   @ Pkg.Artifacts ~/Julia/depot/juliaup/julia-1.8.0-rc3+0.x64/share/julia/stdlib/v1.8/Pkg/src/Artifacts.jl:45
 [6] make_interactive_report(report_type::String, ARGS::Vector{Any})
   @ BugReporting ~/Julia/pkg/BugReporting/src/BugReporting.jl:233
 [7] make_interactive_report(report_type::String)
   @ BugReporting ~/Julia/pkg/BugReporting/src/BugReporting.jl:212
 [8] top-level scope
   @ REPL[2]:1

I'll update the error message to highlight that changes to sysctl.conf require a reboot.