Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on v1.11, run them on pre-release too #393

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Fix tests on v1.11, run them on pre-release too #393

merged 4 commits into from
Nov 13, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jul 18, 2024

The new syntax 'lts' and 'pre' for GitHub actions adapts to the current LTS and pre-release versions. Pre-release is much more stable than nightly when it exists, so it's a good place to check for future issues

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (aa3d197) to head (b993f9d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.01%     
==========================================
  Files         120      117       -3     
  Lines        6953     6948       -5     
==========================================
- Hits         6766     6761       -5     
  Misses        187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member Author

gdalle commented Jul 25, 2024

JET complains because of traits

@gdalle gdalle closed this Oct 20, 2024
@gdalle gdalle reopened this Oct 20, 2024
@simonschoelly
Copy link
Member

Isn't v1.10 the new lts? In that case we should still keep the check for the lower bound version v1.6 until we decide to raise that version in Project.toml.

@gdalle
Copy link
Member Author

gdalle commented Nov 6, 2024

Agreed, I'll open a separate PR to bump the compat

@gdalle gdalle changed the title Test on LTS and pre-release with new syntax 'lts' and 'pre' Test on v1 (now 1.11) and pre-release instead of nightly Nov 6, 2024
@gdalle gdalle changed the title Test on v1 (now 1.11) and pre-release instead of nightly Test on pre-release Nov 6, 2024
@gdalle
Copy link
Member Author

gdalle commented Nov 6, 2024

I made the JET tests slightly less sensitive (:typo pass instead of :basic pass) until we figure out the trait union split. See https://aviatesk.github.io/JET.jl/dev/jetanalysis/#JET.JETAnalyzer

@gdalle gdalle requested a review from simonschoelly November 6, 2024 10:14
@gdalle gdalle changed the title Test on pre-release Test on pre-release, fix failing JET test Nov 6, 2024
@gdalle gdalle changed the title Test on pre-release, fix failing JET test Fix tests on v1.11, run them on pre-release too Nov 6, 2024
@gdalle
Copy link
Member Author

gdalle commented Nov 10, 2024

@simonschoelly this is a very small change but it is necessary for the tests in 1.11 to actually be informative instead of always failing. If you have no objections I'd like to merge it?

Copy link
Member

@simonschoelly simonschoelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes of course

@gdalle gdalle merged commit 24539fd into master Nov 13, 2024
12 checks passed
@gdalle gdalle deleted the gd/test branch November 13, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants