-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on v1.11, run them on pre-release too #393
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 97.31% 97.30% -0.01%
==========================================
Files 120 117 -3
Lines 6953 6948 -5
==========================================
- Hits 6766 6761 -5
Misses 187 187 ☔ View full report in Codecov by Sentry. |
JET complains because of traits |
Isn't |
Agreed, I'll open a separate PR to bump the compat |
I made the JET tests slightly less sensitive ( |
@simonschoelly this is a very small change but it is necessary for the tests in 1.11 to actually be informative instead of always failing. If you have no objections I'd like to merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes of course
The new syntax
'lts'
and'pre'
for GitHub actions adapts to the current LTS and pre-release versions. Pre-release is much more stable than nightly when it exists, so it's a good place to check for future issues