Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver issues (could you consider releasing version 1.0 or continuing with 0.27.xxx) #1605

Closed
Krastanov opened this issue Jun 17, 2021 · 1 comment

Comments

@Krastanov
Copy link

I was very excited to use the new 0.27 version, mainly because of the outdated warnings feature (thank you for making all of that!). However, my documentation requires packages that extend Documenter and because of how Documenter does version numbering I had to wait for them to update their compat versions, even though Documenter was not introducing breaking changes.

To avoid similar issues, could you consider continuing forward with version 1.0 or doing 0.27.1 instead of 0.28? I think I am not suggesting anything controversial as that is the julia prescription for semver <1.0. I think this PSA pinned by Stefan Karpinski confirms that: https://discourse.julialang.org/t/psa-if-your-packages-version-is-of-the-form-0-y-z-please-do-not-bump-the-minor-version-for-new-features/46570

@mortenpi
Copy link
Member

mortenpi commented Jun 17, 2021

I briefly addressed this here: https://discourse.julialang.org/t/ann-documenter-0-27/62726/17

As for packages that are extending Documenter: if they depend on Documenter, they are likely diving into the internals, none of which is technically part of the public API. So there is a very good chance that some refactoring of the internals will break the dependent packages. So I would argue that, for now, it is actually good if the developers of the extensions are being force to verify that their package still works any time we make some non-trivial amount of changes.

All that said, I do not disagree that we would ideally do better with this. It is just that Documenter is somewhat complex, and so getting semver right for it requires time and effort. In the meanwhile, my opinion is that putting a tiny bit of extra work on the users' shoulders is an acceptable trade-off if it means we avoid breaking their setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants