Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.9.27 breaks older Revise versions #602

Closed
fingolfin opened this issue Dec 1, 2023 · 2 comments
Closed

Version 0.9.27 breaks older Revise versions #602

fingolfin opened this issue Dec 1, 2023 · 2 comments

Comments

@fingolfin
Copy link
Contributor

Due to a bug in current Revise.jl versions, I am still using Revise 3.4.0.

But this got broken by the updated of JuliaInterpreter to 0.9.27:

julia> using Revise
[ Info: Precompiling Revise [295af30f-e4ad-537b-8983-00126c2a3abe]
ERROR: LoadError: UndefVarError: `is_GotoIfNot` not defined
Stacktrace:
 [1] include
   @ ./Base.jl:457 [inlined]
 [2] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2049
 [3] top-level scope
   @ stdin:3
in expression starting at /Users/mhorn/.julia/packages/Revise/do2nH/src/Revise.jl:1
in expression starting at stdin:3
ERROR: Failed to precompile Revise [295af30f-e4ad-537b-8983-00126c2a3abe] to "/Users/mhorn/.julia/compiled/v1.9/Revise/jl_bcJhkz".
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
   @ Base ./loading.jl:2294
 [3] compilecache
   @ ./loading.jl:2167 [inlined]
 [4] _require(pkg::Base.PkgId, env::String)
   @ Base ./loading.jl:1805
 [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
   @ Base ./loading.jl:1660
 [6] macro expansion
   @ ./loading.jl:1648 [inlined]
 [7] macro expansion
   @ ./lock.jl:267 [inlined]
 [8] require(into::Module, mod::Symbol)
   @ Base ./loading.jl:1611

For now I solved this by pinning JuliaInterpreter to 0.9.26.

But I wonder if perhaps you would consider to yank 0.9.27 and re-release it as 0.10.0?

@aviatesk
Copy link
Member

Sorry for being late to reply, but is this still issue for you?

@visr
Copy link

visr commented Feb 14, 2024

I guess this is not an issue anymore since the downstream packages have adapted. I just fixed part of that in vscode-julia, julia-vscode/julia-vscode#3541.

@timholy timholy closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants