Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_command: switch to enums? #160

Closed
timholy opened this issue Mar 16, 2019 · 2 comments
Closed

debug_command: switch to enums? #160

timholy opened this issue Mar 16, 2019 · 2 comments
Assignees
@KristofferC

Comments

@timholy
Copy link
Member

timholy commented Mar 16, 2019

In #140 the consensus seems to be to use enums. Should we make the same move in debug_command?
@KristofferC
Copy link
Member

I tried it out a bit but imo the unfortunate truth is that enums are just not that good in Julia. The lack of namespacing is the biggest issue.

I suggest we just swap over to enums since that is consistent with what a lot of the rest of the ecosystem use.

@KristofferC KristofferC self-assigned this Mar 16, 2019
@timholy timholy mentioned this issue Mar 16, 2019
Merged
@timholy
Copy link
Member Author

timholy commented Mar 16, 2019

Choosing Symbols, see #162

@timholy timholy closed this as completed Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristofferC KristofferC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KristofferC @timholy