similar(pa, 0) stopped working

[rikhuijzer]

When working on a PR for Gadfly.jl (GiovineItalia/Gadfly.jl#1521), I noticed that the update for PooledArrays.jl is breaking. I'm not sure whether this behavior is expected, so decided to check in.

With PooledArrays v1.1:

julia> using PooledArrays

julia> pa = PooledArray([1]);

julia> similar(pa, 0)
0-element PooledVector{Int64, UInt32, Vector{UInt32}}

With PooledArrays v1.2:

julia> similar(pa, 0)
ERROR: ArgumentError: collection must be non-empty
Stacktrace:
 [1] _extrema_itr
   @ ./operators.jl:483 [inlined]
 [2] _extrema_dims
   @ ./multidimensional.jl:1698 [inlined]
 [3] #extrema#488
   @ ./multidimensional.jl:1685 [inlined]
 [4] extrema
   @ ./multidimensional.jl:1685 [inlined]
 [5] PooledVector{Int64, UInt32, Vector{UInt32}}(rs::PooledArrays.RefArray{Vector{UInt32}}, invpool::Dict{Int64, UInt32}, pool::Vector{Int64}, refcount::Base.Threads.Atomic{Int64})
   @ PooledArrays ~/.julia/packages/PooledArrays/mXlIN/src/PooledArrays.jl:46
 [6] PooledArray
   @ ~/.julia/packages/PooledArrays/mXlIN/src/PooledArrays.jl:78 [inlined]
 [7] similar(pa::PooledVector{Int64, UInt32, Vector{UInt32}}, S::Type, dims::Tuple{Int64})
   @ PooledArrays ~/.julia/packages/PooledArrays/mXlIN/src/PooledArrays.jl:293
 [8] similar(a::PooledVector{Int64, UInt32, Vector{UInt32}}, dims::Int64)
   @ Base ./abstractarray.jl:735
 [9] top-level scope
   @ REPL[5]:1

[bkamins]

This is fixed by #60. I am just waiting for @nalimilan to approve.

[rikhuijzer]

Hmm, I could just have checked the PRs. Okay, thanks 👍