Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view of PooledArray #44

Open
bkamins opened this issue Nov 30, 2020 · 2 comments
Open

view of PooledArray #44

bkamins opened this issue Nov 30, 2020 · 2 comments

Comments

@bkamins
Copy link
Member

bkamins commented Nov 30, 2020

CategoricalArrays.jl handles DataAPI.refarray, DataAPI.refvalue, and DataAPI.refpool correctly for views. I propose to add the same for PooledArrays.jl (now views return nothing from DataAPI.refpool).

@oxinabox
Copy link
Contributor

oxinabox commented Apr 1, 2021

It would also be good if views of PooledArrays still had fast map that runs once per pool element

function Base.map(f, x::PooledArray{T,R}) where {T,R<:Integer}

@bkamins
Copy link
Member Author

bkamins commented Apr 1, 2021

Related is: #36.

Also the problem is that function passed to map does not have to be pure, in which case you should apply it to each element of the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants