-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for optional fields? #40
Comments
Sorry, I now know somewhat better what I'm talking about and I now know what my issues were. So yes, it appears flatbuffers wants you to allow for the possibility of all fields being optional. What "optional" means in the corresponding Julia Anyway, this brings me to a bigger question. Right now the Julia convenience macros are missing a few features such as setting some reasonable default field values and two of the default constructors. I would say that, at the very least, if we do not anticipate the What are everyone's thoughts on having a few additional macros which generate the above? I'm currently working on overhauling Arrow, so I might make sense for me to make a PR for this so that I could use it there. |
Glad to hear any suggestions and happy to review PRs. I also left a comment in the |
Cool thanks. If I have a specific plan I'll post it here. Whether I take this on will depend on how much I feel I need it for Arrow.jl. |
I'm not sure I really understand what's going on here yet, so forgive me if this is a stupid question, but it seems to me that FlatBuffer fields are always optional, however this package does not seem to support that as the constructors it defines to not seem to allow undefined fields.
Is this a missing feature, or am I just missing something here?
The text was updated successfully, but these errors were encountered: