From 41ef220ba7cb85ebd2ad3c5299adc0cdd5952532 Mon Sep 17 00:00:00 2001 From: Peter Gagarinov Date: Mon, 19 Apr 2021 19:11:20 +0300 Subject: [PATCH] Increase the elapsed time upper boundary for the optimized version of recode --- test/16_recode.jl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/16_recode.jl b/test/16_recode.jl index 32284c8d..de0da931 100644 --- a/test/16_recode.jl +++ b/test/16_recode.jl @@ -10,9 +10,10 @@ end const ≅ = isequal function test_recode_performance(orig_vec, cat2merge_vec) - # the optimized version should take 20-70 milliseconds while unoptimized version takes > 1 sec - # thus setting MAX_RECODE_TIME_IN_SEC to 0.2 seconds seems robust enough - MAX_RECODE_TIME_IN_SEC = 0.2 + # the optimized version should take from 20 milliseconds (physical CPU) up to 340 milliseconds + # (GitHub actions) while unoptimized version takes > 1 sec + # thus setting MAX_RECODE_TIME_IN_SEC to 0.55 seconds seems robust enough + MAX_RECODE_TIME_IN_SEC = 0.55 recode(orig_vec, cat2merge_vec => "None"); time_elapsed = @elapsed recode(orig_vec, cat2merge_vec => "None"); @test time_elapsed <= MAX_RECODE_TIME_IN_SEC;