-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting of FilterCoefficients #226
Comments
This does look nice. I think I'd be Ok with adding adding a dependency on RecipesBase and adding this code, but if others prefer to have it live in a dedicated package I wouldn't mind either. |
@martinholters I'm happy to submit a PR to DSP.jl or create "DSPPlots.jl". |
I think a RecipesBase dependency is fine, and this doesn't need to be split out into a separate package. |
We now transitively depend on RecipesBase anyway (via Polynomials), so even less reason not to do this. |
I'm following up on this StatPlots.jl issue: JuliaPlots/StatsPlots.jl#147
And I'm unsure if I can re-open this DSP.jl issue: #203
I have a reasonable prototype of code using RecipesBase.jl here:
https://gist.github.com/standarddeviant/0e676140feca9b938943ebeded05b8e1
The main recipe handles a vector of FilterCoefficients, and there's a version that handles a single FilterCoefficients by making a length-1 vector of FilterCoefficients. I've found this useful to look at time/frequency tradeoffs when varying a single filter parameter.
If you download and run that file, this is a fun plot to make:
The julia dot-syntax is wonderful :-)

I'm just offering this up as a potential solution to being able to plot and visualize filters in DSP.jl.
The text was updated successfully, but these errors were encountered: